From 5f9c05e351d2227aad588a8e99b73ec1bb9221a4 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Mon, 19 Oct 2026 15:58:20 -0700 Subject: [PATCH 1/2] feat(settings): explain beside Antigravity's sign-in why the agy CLI login doesn't carry over --- .../settings/AntigravityChatSignInRow.tsx | 43 ++++++++++++++----- .../AntigravityProviderSignInArea.tsx | 22 ++++++---- src/renderer/src/i18n/locales/en.json | 2 + src/renderer/src/i18n/locales/es.json | 2 + src/renderer/src/i18n/locales/fr.json | 2 + src/renderer/src/i18n/locales/ja.json | 2 + src/renderer/src/i18n/locales/ko.json | 2 + src/renderer/src/i18n/locales/zh.json | 2 + 8 files changed, 58 insertions(+), 19 deletions(-) diff --git a/src/renderer/src/components/settings/AntigravityChatSignInRow.tsx b/src/renderer/src/components/settings/AntigravityChatSignInRow.tsx index bbfda57cfbca..aec48d756087 100644 --- a/src/renderer/src/components/settings/AntigravityChatSignInRow.tsx +++ b/src/renderer/src/components/settings/AntigravityChatSignInRow.tsx @@ -1,5 +1,5 @@ import { useEffect, useId, useState, useSyncExternalStore } from 'react' -import { Check, Copy } from 'lucide-react' +import { Check, Copy, Info } from 'lucide-react' import { translate } from '@/i18n/i18n' import { useClipboardTextCopyFeedback } from '@/hooks/use-clipboard-text-copy-feedback' import { @@ -202,6 +202,26 @@ export function PastedAddressForm(props: { ) } +/** Beside the sign-in button: users expect their agy CLI login to carry over to chats. */ +export function AntigravityChatSignInInfo(): React.JSX.Element { + const label = translate('accounts.antigravity.chatSignInInfoLabel', 'About Antigravity sign-in') + return ( + + + + + + {translate( + 'accounts.antigravity.chatSignInInfo', + "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here." + )} + + + ) +} + /** One host's chat sign-in as both Settings layouts show it. `signedOut` is the line for a host * that answered it is not signed in. */ export function useAntigravityChatSignInControls(props: { @@ -319,15 +339,18 @@ export function AntigravityChatSignInRow(props: { ) : ( - +
+ + +
)} {url && } diff --git a/src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx b/src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx index 468589cd82da..7dc253cad4b9 100644 --- a/src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx +++ b/src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx @@ -5,6 +5,7 @@ import type { RuntimeClientTarget } from '../../../../shared/runtime-client-targ import { LoadingSpinner } from '../LoadingSpinner' import { Button } from '../ui/button' import { + AntigravityChatSignInInfo, PastedAddressForm, antigravityChatSignInBlocked, useAntigravityChatSignInControls @@ -76,15 +77,18 @@ export function AntigravityProviderSignInArea(props: { ) : ( - + <> + + + )} {url && } diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index f37b4bf61931..3cf1340c0d18 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -20063,6 +20063,8 @@ "chatTitle": "Antigravity chats", "chatDescription": "Chats use their own Antigravity sign-in, separate from your agy account above. Sign in once on this device.", "chatSignIn": "Sign in", + "chatSignInInfoLabel": "About Antigravity sign-in", + "chatSignInInfo": "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here.", "chatChangeAccount": "Change account", "chatRetry": "Retry sign-in", "chatCancel": "Cancel", diff --git a/src/renderer/src/i18n/locales/es.json b/src/renderer/src/i18n/locales/es.json index e7865d95cef8..e8fb46060805 100644 --- a/src/renderer/src/i18n/locales/es.json +++ b/src/renderer/src/i18n/locales/es.json @@ -19693,6 +19693,8 @@ "chatTitle": "Chats de Antigravity", "chatDescription": "Los chats usan su propio inicio de sesión de Antigravity, independiente de tu cuenta de agy de arriba. Inicia sesión una vez en este dispositivo.", "chatSignIn": "Iniciar sesión", + "chatSignInInfoLabel": "Acerca del inicio de sesión de Antigravity", + "chatSignInInfo": "Los chats de Antigravity tienen su propio inicio de sesión. Iniciar sesión en la CLI de agy no inicia sesión aquí.", "chatChangeAccount": "Cambiar de cuenta", "chatRetry": "Reintentar inicio de sesión", "chatCancel": "Cancelar", diff --git a/src/renderer/src/i18n/locales/fr.json b/src/renderer/src/i18n/locales/fr.json index 18e4801a941d..0b27f2a0cbbe 100644 --- a/src/renderer/src/i18n/locales/fr.json +++ b/src/renderer/src/i18n/locales/fr.json @@ -19850,6 +19850,8 @@ "chatTitle": "Discussions Antigravity", "chatDescription": "Les discussions utilisent leur propre connexion Antigravity, distincte de votre compte agy ci-dessus. Connectez-vous une seule fois sur cet appareil.", "chatSignIn": "Se connecter", + "chatSignInInfoLabel": "À propos de la connexion Antigravity", + "chatSignInInfo": "Les chats Antigravity ont leur propre connexion. Se connecter à la CLI agy ne vous connecte pas ici.", "chatChangeAccount": "Changer de compte", "chatRetry": "Réessayer la connexion", "chatCancel": "Annuler", diff --git a/src/renderer/src/i18n/locales/ja.json b/src/renderer/src/i18n/locales/ja.json index 5c1ad4df6f38..008d07dfd138 100644 --- a/src/renderer/src/i18n/locales/ja.json +++ b/src/renderer/src/i18n/locales/ja.json @@ -19850,6 +19850,8 @@ "chatTitle": "Antigravity チャット", "chatDescription": "チャットは上の agy アカウントとは別の、独自の Antigravity サインインを使用します。このデバイスで一度サインインしてください。", "chatSignIn": "サインイン", + "chatSignInInfoLabel": "Antigravity のサインインについて", + "chatSignInInfo": "Antigravity チャットには専用のサインインがあります。agy CLI にサインインしても、ここではサインインされません。", "chatChangeAccount": "アカウントを変更", "chatRetry": "サインインを再試行", "chatCancel": "キャンセル", diff --git a/src/renderer/src/i18n/locales/ko.json b/src/renderer/src/i18n/locales/ko.json index 1296bd6067fe..6cbcf8dbff96 100644 --- a/src/renderer/src/i18n/locales/ko.json +++ b/src/renderer/src/i18n/locales/ko.json @@ -19850,6 +19850,8 @@ "chatTitle": "Antigravity 채팅", "chatDescription": "채팅은 위의 agy 계정과 별개인 자체 Antigravity 로그인을 사용합니다. 이 기기에서 한 번 로그인하세요.", "chatSignIn": "로그인", + "chatSignInInfoLabel": "Antigravity 로그인 정보", + "chatSignInInfo": "Antigravity 채팅은 별도로 로그인합니다. agy CLI에 로그인해도 여기에는 로그인되지 않습니다.", "chatChangeAccount": "계정 변경", "chatRetry": "로그인 다시 시도", "chatCancel": "취소", diff --git a/src/renderer/src/i18n/locales/zh.json b/src/renderer/src/i18n/locales/zh.json index 0eb69a3c6d7c..9f188a99f352 100644 --- a/src/renderer/src/i18n/locales/zh.json +++ b/src/renderer/src/i18n/locales/zh.json @@ -19850,6 +19850,8 @@ "chatTitle": "Antigravity 聊天", "chatDescription": "聊天使用自己的 Antigravity 登录，与上方的 agy 帐户分开。在此设备上登录一次即可。", "chatSignIn": "登录", + "chatSignInInfoLabel": "关于 Antigravity 登录", + "chatSignInInfo": "Antigravity 聊天有单独的登录。登录 agy CLI 不会在这里登录。", "chatChangeAccount": "更换帐户", "chatRetry": "重试登录", "chatCancel": "取消", From a15dcf1b10953ef15011a936c78a9b75be7a29c0 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Mon, 19 Oct 2026 20:33:54 -0700 Subject: [PATCH 2/2] test(settings): render the Providers sign-in area inside the tooltip provider --- .../AntigravityChatSignInRow.test.tsx | 44 ++++++++++--------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsx b/src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsx index 88980f2aa3c6..09d870d5490f 100644 --- a/src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsx +++ b/src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsx @@ -163,28 +163,30 @@ it('sends the address pasted from a browser on another computer to the host', as it("names the account and why it's needed before the host knows its sign-in", async () => { const owner = { kind: 'environment', environmentId: 'provider-unanswered' } as const render( - + + }} + /> + ) await act(async () => undefined) expect(screen.getByText('Account')).toBeTruthy()