From 5f652fc61ea64ffdcff7bfbf6cf625b61c811b6d Mon Sep 17 00:00:00 2001
From: Paul Itoi <814886+pitoi@users.noreply.github.com>
Date: Mon, 31 Aug 2026 03:40:27 +0000
Subject: [PATCH] [Jamie] Fix ambiguous 'Failed' text query and Badge mock
 prop-forwarding in benchmark tests

Fixes 2 remaining unit test failures on PR #5207 caused by the new Passed/Failed/Total columns exposing pre-existing test fragility (not caused by the column-split logic itself).
---
 src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx | 6 +++++-
 .../legal/BenchmarkRunsHistory-breakdown.test.tsx           | 4 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx b/src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
index 0a8928ed8c..149d34bbfa 100644
--- a/src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
+++ b/src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
@@ -867,7 +867,11 @@ describe("BenchmarkRunsHistory", () => {
       setExpandedId: mockSetExpandedId,
     });
     render(React.createElement(BenchmarkRunsHistory));
-    expect(screen.getByText("Failed")).toBeInTheDocument();
+    const failedMatches = screen.getAllByText("Failed");
+    expect(failedMatches.length).toBeGreaterThan(0);
+    expect(
+      failedMatches.some((el) => el.className.includes("text-destructive")),
+    ).toBe(true);
   });
 
   it("shows dash (not Pending) for a FAILED run with generateJamieChat (report will never fire)", () => {
diff --git a/src/__tests__/unit/components/legal/BenchmarkRunsHistory-breakdown.test.tsx b/src/__tests__/unit/components/legal/BenchmarkRunsHistory-breakdown.test.tsx
index 63b2210b0e..63612f7460 100644
--- a/src/__tests__/unit/components/legal/BenchmarkRunsHistory-breakdown.test.tsx
+++ b/src/__tests__/unit/components/legal/BenchmarkRunsHistory-breakdown.test.tsx
@@ -76,8 +76,8 @@ vi.mock("@/components/legal/HillClimbChart", () => ({
 }));
 
 vi.mock("@/components/ui/badge", () => ({
-  Badge: ({ children, className }: { children?: React.ReactNode; className?: string }) => (
-    <span data-testid="badge" className={className}>{children}</span>
+  Badge: ({ children, className, ...rest }: { children?: React.ReactNode; className?: string; [key: string]: unknown }) => (
+    <span data-testid="badge" className={className} {...rest}>{children}</span>
   ),
 }));