Skip to content

feat: allow string input for setLogLevel #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AuHau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow string input for setLogLevel #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion chronicles/topics_registry.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import locks, macros, tables
import locks, macros, tables, strutils
from options import LogLevel

export
Expand Down Expand Up @@ -40,6 +40,10 @@ proc setLogLevel*(lvl: LogLevel) =
lockRegistry:
gActiveLogLevel = lvl

proc setLogLevel*(lvl: string) =
lockRegistry:
gActiveLogLevel = parseEnum[LogLevel](lvl.toUpperAscii)

proc clearTopicsRegistry* =
lockRegistry:
gTotalEnabledTopics = 0
Expand Down
9 changes: 9 additions & 0 deletions tests/runtime_filtering.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,12 @@ echo setTopicState("bar", Normal)

foo()
bar()

echo "> set global LogLevel to string warn, set main and foo to INFO, both should print:"
setLogLevel("warn")
echo setTopicState("main", Normal, INFO)
echo setTopicState("foo", Normal, INFO)
echo setTopicState("bar", Normal)

foo()
bar()