Skip to content

fix(@desktop): add missing visual identity elements#5064

Merged
osmaczko merged 2 commits into
masterfrom
fix/emojihash-identiconring
Mar 17, 2022
Merged

fix(@desktop): add missing visual identity elements#5064
osmaczko merged 2 commits into
masterfrom
fix/emojihash-identiconring

Conversation

@osmaczko

@osmaczko osmaczko commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

What does the PR do

Screenshot of functionality

image
image

@status-im-auto

status-im-auto commented Mar 16, 2022

Copy link
Copy Markdown
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 80b2436 #1 2022-03-16 21:35:20 ~11 min linux 📦tgz
✔️ 80b2436 #1 2022-03-16 21:44:07 ~20 min macos 📦dmg
✔️ 80b2436 #1 2022-03-16 21:46:03 ~21 min windows 📦exe
✔️ bf6fc74 #2 2022-03-17 10:38:42 ~7 min macos 📦dmg
✔️ bf6fc74 #2 2022-03-17 10:41:07 ~9 min linux 📦tgz
✔️ bf6fc74 #2 2022-03-17 10:49:59 ~18 min windows 📦exe

Removed instances of VisualIdentityService as it was stateless.
Removed (emoji/color)Hash models as they were reduntant, hashes are
obtained only from global utility now.
@osmaczko osmaczko requested a review from alexandraB99 March 17, 2022 10:32

@jrainville jrainville left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Clean changes.

FYI, I have two PRs that might conflict with this:

  • This fix to the chat_section module: #5063
    • I think my PR now is useless, because you just removed all the code from the chat_section, but can you confirm if in your PR we can join a public chat without crash? If so, I'll delete my PR.
  • This change to the contact setting: #5053
    • I don't think you touched the Contact setting yourself, so it should be good, but posting here just in case.

@osmaczko

Copy link
Copy Markdown
Contributor Author
  • I think my PR now is useless, because you just removed all the code from the chat_section, but can you confirm if in your PR we can join a public chat without crash? If so, I'll delete my PR.

Yes, indeed, didn't know it crashes... You can delete it, as I removed visual identity service instances altogether.

  • I don't think you touched the Contact setting yourself, so it should be good, but posting here just in case.

I intentionally omitted the Contact settings, cause you mentioned in the previous PR it would conflict.

@osmaczko osmaczko merged commit e244260 into master Mar 17, 2022
@osmaczko osmaczko deleted the fix/emojihash-identiconring branch March 17, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants