fix(@desktop): add missing visual identity elements#5064
Merged
Conversation
Member
Jenkins Builds
|
Removed instances of VisualIdentityService as it was stateless. Removed (emoji/color)Hash models as they were reduntant, hashes are obtained only from global utility now.
jrainville
approved these changes
Mar 17, 2022
jrainville
left a comment
Member
There was a problem hiding this comment.
Looks good. Clean changes.
FYI, I have two PRs that might conflict with this:
- This fix to the chat_section module: #5063
- I think my PR now is useless, because you just removed all the code from the chat_section, but can you confirm if in your PR we can join a public chat without crash? If so, I'll delete my PR.
- This change to the contact setting: #5053
- I don't think you touched the Contact setting yourself, so it should be good, but posting here just in case.
alexandraB99
approved these changes
Mar 17, 2022
Contributor
Author
Yes, indeed, didn't know it crashes... You can delete it, as I removed visual identity service instances altogether.
I intentionally omitted the Contact settings, cause you mentioned in the previous PR it would conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Removed instances of VisualIdentityService as it was stateless.
Removed (emoji/color)Hash models as they were reduntant, hashes are
obtained only from global utility now.
Screenshot of functionality