Add Polyfill package and polyfill additional things manually

Author: DavidZidar

src/Directory.Packages.props

@@ -9,6 +9,10 @@
     <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.0" />
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageVersion Include="Polyfill" Version="9.0.3" />
+  </ItemGroup>
+
   <ItemGroup>
     <GlobalPackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" />
     <GlobalPackageReference Include="Roslynator.Analyzers" Version="4.14.1" />

src/TinyHotKey/ITinyHotKey.cs

@@ -17,43 +17,3 @@ public interface ITinyHotKey
 	/// <returns>Registration status, check IsRegistered to see if the registration was successful, dispose when done to remove the hotkey detection.</returns>
 	ITinyHotKeyRegistration RegisterHotKey(Modifier modifiers, Key key, Func<Task> callback);
 }
-
-public static class TinyHotKeyExtensions
-{
-	extension(ITinyHotKey tinyHotKey)
-	{
-		/// <summary>
-		/// <para>Register a callback to be invoke when a keyboard combination is detected.</para>
-		/// <para>
-		/// Since only one application at a time may listen to a certain keyboard combination on Windows
-		/// this method will throw an error if the registration was not a success.
-		/// </para>
-		/// <para>Multiple registrations for the same keyboard combination with the same instance is ok.</para>
-		/// </summary>
-		/// <param name="modifiers">Modifier keys, eg. Modifier.Ctrl | Modifier.Alt or Modifier.None</param>
-		/// <param name="key">Key to detect, eg. Key.C or Key.MediaPlayPause</param>
-		/// <param name="callback">Callback to be invoked when the keyboard combination is detected</param>
-		/// <returns>Registration status, should always be successful with this overload, dispose when done to remove the hotkey detection.</returns>
-		/// <exception cref="InvalidOperationException">Thrown when the hotkey combination could not be registered.</exception>
-		public ITinyHotKeyRegistration RegisterHotKeyOrThrow(Modifier modifiers, Key key, Func<Task> callback)
-		{
-#if NET
-			ArgumentNullException.ThrowIfNull(tinyHotKey);
-#else
-			if (tinyHotKey is null)
-			{
-				throw new ArgumentNullException(nameof(tinyHotKey));
-			}
-#endif
-
-			var registration = tinyHotKey.RegisterHotKey(modifiers, key, callback);
-
-			if (!registration.IsRegistered)
-			{
-				throw new InvalidOperationException($"Couldn't register hotkey {modifiers} {key}");
-			}
-
-			return registration;
-		}
-	}
-}

src/TinyHotKey/Polyfills/ArgumentNullExceptionExtensions.cs

@@ -0,0 +1,19 @@
+#if !NET
+using System.Runtime.CompilerServices;
+
+namespace System;
+
+internal static class ArgumentNullExceptionExtensions
+{
+	extension(ArgumentNullException)
+	{
+		public static void ThrowIfNull(object? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
+		{
+			if (argument is null)
+			{
+				throw new ArgumentNullException(paramName);
+			}
+		}
+	}
+}
+#endif

src/TinyHotKey/TinyHotKey.csproj

@@ -16,4 +16,8 @@
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
   </ItemGroup>
 
+  <ItemGroup Condition=" '$(TargetFramework)' != 'net10.0' ">
+    <PackageReference Include="Polyfill" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers" />
+  </ItemGroup>
+
 </Project>

src/TinyHotKey/TinyHotKeyExtensions.cs

@@ -0,0 +1,34 @@
+namespace TinyHotKey;
+
+public static class TinyHotKeyExtensions
+{
+	extension(ITinyHotKey tinyHotKey)
+	{
+		/// <summary>
+		/// <para>Register a callback to be invoke when a keyboard combination is detected.</para>
+		/// <para>
+		/// Since only one application at a time may listen to a certain keyboard combination on Windows
+		/// this method will throw an error if the registration was not a success.
+		/// </para>
+		/// <para>Multiple registrations for the same keyboard combination with the same instance is ok.</para>
+		/// </summary>
+		/// <param name="modifiers">Modifier keys, eg. Modifier.Ctrl | Modifier.Alt or Modifier.None</param>
+		/// <param name="key">Key to detect, eg. Key.C or Key.MediaPlayPause</param>
+		/// <param name="callback">Callback to be invoked when the keyboard combination is detected</param>
+		/// <returns>Registration status, should always be successful with this overload, dispose when done to remove the hotkey detection.</returns>
+		/// <exception cref="InvalidOperationException">Thrown when the hotkey combination could not be registered.</exception>
+		public ITinyHotKeyRegistration RegisterHotKeyOrThrow(Modifier modifiers, Key key, Func<Task> callback)
+		{
+			ArgumentNullException.ThrowIfNull(tinyHotKey);
+
+			var registration = tinyHotKey.RegisterHotKey(modifiers, key, callback);
+
+			if (!registration.IsRegistered)
+			{
+				throw new InvalidOperationException($"Couldn't register hotkey {modifiers} {key}");
+			}
+
+			return registration;
+		}
+	}
+}

src/TinyHotKey/TinyHotKeyInstance.cs

@@ -17,12 +17,10 @@ public TinyHotKeyInstance()
 
 	public TinyHotKeyInstance(ILoggerFactory? loggerFactory)
 	{
-#if NET
 		if (!OperatingSystem.IsWindows())
 		{
 			throw new PlatformNotSupportedException("Operating system not supported");
 		}
-#endif
 
 		platformInstance = new TinyHotKeyWindows(loggerFactory?.CreateLogger("TinyHotKey"));
 	}

src/TinyHotKey/TinyHotKeyWindows.cs

@@ -3,9 +3,7 @@
 using System.Diagnostics.CodeAnalysis;
 #endif
 using System.Runtime.InteropServices;
-#if NET
 using System.Runtime.Versioning;
-#endif
 using Microsoft.Extensions.Logging;
 
 namespace TinyHotKey;
@@ -17,19 +15,13 @@ namespace TinyHotKey;
 /// which only works thanks to a hidden Window and a custom message loop on a
 /// dedicated thread.
 /// </summary>
-#if NET
 [SupportedOSPlatform("windows")]
-#endif
 internal sealed partial class TinyHotKeyWindows : ITinyHotKey, IDisposable
 {
 	private readonly string className = Guid.NewGuid().ToString("n");
 	private readonly AutoResetEvent messageLoopDone = new(false);
 	private readonly ILogger? logger;
-#if NET9_0_OR_GREATER
 	private readonly Lock registrationLock = new();
-#else
-	private readonly object registrationLock = new();
-#endif
 	private readonly List<TinyHotKeyRegistration> registrations = [];
 	private readonly WndProc wndProcDelegate;