From 99870ba339a45ff6a81a3a32dce9e21829edcc6b Mon Sep 17 00:00:00 2001 From: Piyal Basu Date: Mon, 22 Jun 2026 16:17:29 -0400 Subject: [PATCH] ci: fix create-release input (target_commitish -> commitish) actions/create-release@v1's input is `commitish`, not `target_commitish`, so the value was silently ignored ("Unexpected input(s) 'target_commitish'") and release tags were created against the repo default branch (master) instead of the built ref. This put 5.42.1-beta.1's tag on master's HEAD rather than the emergency-release commit it was built from. Use the correct key so beta/prod release tags point at the actual built commit. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/submitBeta.yml | 2 +- .github/workflows/submitProduction.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/submitBeta.yml b/.github/workflows/submitBeta.yml index 64a09eb644..63e56e7332 100644 --- a/.github/workflows/submitBeta.yml +++ b/.github/workflows/submitBeta.yml @@ -129,7 +129,7 @@ jobs: github.event.inputs.version }} draft: false prerelease: true - target_commitish: ${{ steps.checkout_sha.outputs.sha }} + commitish: ${{ steps.checkout_sha.outputs.sha }} - name: Upload Release Asset id: upload-release-asset uses: actions/upload-release-asset@v1 diff --git a/.github/workflows/submitProduction.yml b/.github/workflows/submitProduction.yml index a9b223b465..9859758eee 100644 --- a/.github/workflows/submitProduction.yml +++ b/.github/workflows/submitProduction.yml @@ -102,7 +102,7 @@ jobs: body: ${{ steps.package_version.outputs.version }} draft: false prerelease: false - target_commitish: ${{ steps.checkout_sha.outputs.sha }} + commitish: ${{ steps.checkout_sha.outputs.sha }} - name: Build for Firefox id: web-ext-build uses: kewisch/action-web-ext@fe10addf5d5e5ba6b78ffde720dd488a27d10e8c #v1