From b5eeca0c481f41f2b72d10562f27f36057183736 Mon Sep 17 00:00:00 2001
From: Thales Pereira <31625914+thcp@users.noreply.github.com>
Date: Mon, 13 Jul 2026 21:28:07 +0100
Subject: [PATCH] fix(ci): docker-publish never fires on `prereleased` --
 restore `published`

Publishing v0.8.0-alpha.7 (a draft prerelease -> published) never triggered
Docker Publish: CI/Linux/Windows/macOS releases all still listen for
`published` and fired correctly, but docker-publish.yml (changed in #259) only
listened for [prereleased, released] -- and `prereleased` did not fire for this
publish. Result: ghcr.io/stemdeckapp/stemdeck:0.8.0-alpha.7 was never pushed,
while the Unraid CA template already points at that (nonexistent) tag.

Fix: trigger on [published, released] -- published is the reliable trigger
every other release workflow already relies on; released is kept for promoting
an already-published prerelease to Latest via the release-label edit. The
:latest condition now also covers a plain non-prerelease `published` (not just
`released`), so a first-time stable release still gets :latest.

Also add a workflow_dispatch `version` input, so a specific tag can be
(re)pushed by hand to recover from a missed trigger without re-touching the
release (which would needlessly re-run the OS build workflows).
---
 .github/workflows/docker-publish.yml | 30 ++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml
index 19e948e..0c49f3d 100644
--- a/.github/workflows/docker-publish.yml
+++ b/.github/workflows/docker-publish.yml
@@ -13,14 +13,22 @@ on:
   push:
     branches: [main]
   release:
-    # prereleased: a prerelease is published -> push the version tag only.
-    # released:    a stable release is published, OR a prerelease is promoted to
-    #              a full/Latest release -> push the version tag AND :latest.
-    # (Listening to these two instead of `published` avoids a double run on a
-    # stable publish, which fires both `published` and `released`.)
-    types: [prereleased, released]
-  # Same as a main push but on demand, from any ref.
+    # published: the reliable trigger -- fires whenever a release (draft or not,
+    # prerelease or not) is published. Confirmed empirically: publishing a draft
+    # prerelease fires `published` but NOT `prereleased` (the v0.8.0-alpha.7
+    # release never got its version tag pushed until this was added back).
+    # released: an already-published prerelease is promoted to a full/Latest
+    # release via the "Release label" edit -- pushes :latest for that case too.
+    types: [published, released]
+  # Same as a main push but on demand, from any ref. `version` lets a specific
+  # tag be (re)pushed by hand -- e.g. to recover from a missed release trigger
+  # without re-touching the release (which would re-run the OS build workflows).
   workflow_dispatch:
+    inputs:
+      version:
+        description: "Version tag to push (e.g. 0.8.0-alpha.7). Leave blank for a git-derived :edge-only push."
+        required: false
+        default: ""
 
 permissions: {}
 
@@ -54,6 +62,8 @@ jobs:
         run: |
           if [ "${{ github.event_name }}" = "release" ]; then
             v="${{ github.event.release.tag_name }}"
+          elif [ -n "${{ github.event.inputs.version }}" ]; then
+            v="${{ github.event.inputs.version }}"
           else
             raw="$(git describe --tags --long 2>/dev/null || echo "0.0.0-0-g$(git rev-parse --short HEAD)")"
             v="$(printf '%s' "${raw#v}" | sed -E 's/-([0-9]+)-g([0-9a-f]+)$/+\1.g\2/')"
@@ -66,9 +76,9 @@ jobs:
         with:
           images: ${{ env.IMAGE }}
           tags: |
-            type=raw,value=edge,enable=${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
-            type=raw,value=${{ steps.ver.outputs.value }},enable=${{ github.event_name == 'release' }}
-            type=raw,value=latest,enable=${{ github.event_name == 'release' && github.event.action == 'released' }}
+            type=raw,value=edge,enable=${{ github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.version == '') }}
+            type=raw,value=${{ steps.ver.outputs.value }},enable=${{ github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && github.event.inputs.version != '') }}
+            type=raw,value=latest,enable=${{ github.event_name == 'release' && (github.event.action == 'released' || (github.event.action == 'published' && !github.event.release.prerelease)) }}
 
       - uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c  # v4.2.0