-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation
Description
README gaps
- Exception hierarchy: No documentation of
AsicTimestampException→TimestampAuthorityException,InvalidAsicContainerException,AsicVerificationException. Consumers don't know which exceptions to catch. - TSA fallback list:
TimestampAuthorityUrlsoption is never mentioned. Noappsettings.jsonexample showing"TimestampAuthorityUrls": ["...", "..."]. - Stream-based
CreateAsync: Not shown in the Quick Start (onlybyte[]and file-path overloads). UseNonceandRequestSignerCertificatesoptions: Both exist onAsicTimestampOptionsbut are never mentioned in the README.AsicVerifyResult.DataBytes: Not mentioned — useful for consumers who want data without callingExtract()separately.- Verification behavior: No explanation that a single failing step causes
IsValid = false, or thatErroris a join of all failed step details.
XML doc comment gaps
Several IAsicService methods have only a summary — missing <param> and <returns>:
CreateAsync(Stream, ...)CreateFromFileAsyncVerifyFileCreateExtendedFromFilesAsyncRenewAsync(Stream, ...)RenewFileAsync
Other gaps:
VerificationStep—Name,Passed,Detailhave no XML docsTimestampChainEntry— no class-level summaryAsicTimestampExceptionsubclasses — no<exception>tags on throwing public methodsAsicVerifyResult.DataBytes— null for ASiC-E not documentedServiceCollectionExtensionsparameterless overload — doesn't mention defaults (DigiCert, SHA-256)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation