Batch fix for six confirmed crash / data-corruption / resource-leak bugs found during a code review of the OneMoreCalendar project.
Issues
BitmapExtensions.MapColor mutates shared resource bitmaps — permanently recolors embedded resource bitmaps; icon colors are wrong after the second theme toggle.SnappedPage STA deadlock — Task.Run(...).Result blocks the STA UI thread while OneNote COM marshals back to it, freezing the window.page.Hyperlink null-deref in ClickCopyPageButton — when GetPageLinks leaves a page with Hyperlink = null (COM error), the next StartsWith call crashes and aborts the clipboard write.Notebook constructor NPE on missing XML attributes — notebooks with no color attribute throw NullReferenceException, crashing the Settings dialog.SettingsProvider.Theme crashes on unrecognized enum value — Enum.Parse throws ArgumentException on hand-edited or future-version XML, crashing form load.YearsForm.HoverMouse leaks GDI handles — two CreateGraphics() objects are never disposed; rapid mouse movement accumulates unreleased HDC handles.
Batch fix for six confirmed crash / data-corruption / resource-leak bugs found during a code review of the OneMoreCalendar project.
Issues
BitmapExtensions.MapColormutates shared resource bitmaps — permanently recolors embedded resource bitmaps; icon colors are wrong after the second theme toggle.SnappedPageSTA deadlock —Task.Run(...).Resultblocks the STA UI thread while OneNote COM marshals back to it, freezing the window.page.Hyperlinknull-deref inClickCopyPageButton— whenGetPageLinksleaves a page withHyperlink = null(COM error), the nextStartsWithcall crashes and aborts the clipboard write.Notebookconstructor NPE on missing XML attributes — notebooks with nocolorattribute throwNullReferenceException, crashing the Settings dialog.SettingsProvider.Themecrashes on unrecognized enum value —Enum.ParsethrowsArgumentExceptionon hand-edited or future-version XML, crashing form load.YearsForm.HoverMouseleaks GDI handles — twoCreateGraphics()objects are never disposed; rapid mouse movement accumulates unreleased HDC handles.