Skip to content

UX / i18n: Redundant phrasing and missing item names in delete confirmation dialogs#128

Description

@yangyws

Description / UX Observation

While reviewing delete confirmation dialogs across the MacroPad editor (Profiles, Layouts, Buttons, Macros, Steps), a few UX and formatting inconsistencies were noticed:

1. 馃攣 Redundant / Duplicate Text

  • Delete Profile (macropad_editor_confirm_delete):
    • Title: Delete Profile
    • Body: Delete this profile? (Repeats the title as a question without stating which profile is being deleted).
  • Delete Macro (macropad_macro_delete_confirm):
    • Title: Delete Macro
    • Body: Delete this macro? Pad buttons that reference it will stop working.

2. 馃敳 Missing Context / Potential Blank Line

  • Delete Layout:
    • Title: Delete Layout
    • Body: {layout.name} (Renders only the raw layout name as the body without sentence context).
  • Delete Button:
    • Title: Delete
    • Body: {button.label} (If the button has no text label or only has an icon, the body is an empty string, rendering an awkward blank space).

Suggested Improvements

  1. Parameterize confirmation messages with target item names:
    • Delete profile "%1$s" and all its layouts? This action cannot be undone.
    • Delete layout "%1$s"? This action cannot be undone.
    • Delete button "%1$s"? (falling back to Delete this button? when unlabeled).
    • Delete macro "%1$s"? This action cannot be undone. / This macro is used by %1$d button(s). Delete "%2$s"?
  2. Multi-line wrapping: Ensure body text in confirmation dialogs has Modifier.fillMaxWidth() to gracefully wrap long profile or macro names across multiple lines.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions