Skip to content

SubmitShares.Success is sending bad values for new_submits_accepted_count and new_shares_sum  #1967

@plebhash

Description

@plebhash

while working on #1966 I had to re-read the specs for SubmitShares.Success and revisit stratum-mining/sv2-spec#126

so I had the following question:

| Field Name                 | Data Type | Description                                         |
| -------------------------- | --------- | --------------------------------------------------- |
| channel_id                 | U32       | Channel identification                              |
| last_sequence_number       | U32       | Most recent sequence number with a correct result   |
| new_submits_accepted_count | U32       | Count of new submits acknowledged within this batch |
| new_shares_sum             | U64       | Sum of difficulty of shares acknowledged within this batch        |

are we implementing new_submits_accepted_count and new_shares_sum correctly in SRI?

currently, when SRI sends a SubmitSharess.Success, it is doing something like:

  • Count of new submits acknowledged SO FAR, including this batch, not within this batch
  • Sum of difficulty of shares acknowledged SO FAR, including this batch, not within this batch

so I ran my BMM100 against Braiins pool with stratum-sniffer to monitor for the SubmitShares.Success messages, and indeed they are sending the messages within this batch, not up until this batch

since they're the spec authors, I take this as confirmation that this was the originally intended interpretation of the spec, and we should adapt to follow that

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions