From 2d652633f3611f530291a78158da162ee25655be Mon Sep 17 00:00:00 2001 From: plebhash Date: Mon, 20 Jan 2025 12:09:19 -0300 Subject: [PATCH 1/2] avoid publishing protocols crates with all-features.. publishing with all-features is overengineering: - with_serde will be deprecated soon - for crates with relevant features, we specifically list them for publishing --- common/Cargo.toml | 3 --- protocols/v1/Cargo.toml | 3 --- roles/roles-utils/network-helpers/Cargo.toml | 2 +- roles/roles-utils/rpc/Cargo.toml | 3 --- utils/bip32-key-derivation/Cargo.toml | 3 --- utils/error-handling/Cargo.toml | 3 --- utils/key-utils/Cargo.toml | 3 --- 7 files changed, 1 insertion(+), 19 deletions(-) diff --git a/common/Cargo.toml b/common/Cargo.toml index b2a01f0ec1..3b9d7cc2cd 100644 --- a/common/Cargo.toml +++ b/common/Cargo.toml @@ -9,6 +9,3 @@ repository = "https://github.com/stratum-mining/stratum" [dependencies] bitcoin = {version="0.29.1",optional=true} secp256k1 = { version = "0.28.2", default-features = false, features =["alloc","rand","rand-std"] } - -[package.metadata.docs.rs] -all-features = true \ No newline at end of file diff --git a/protocols/v1/Cargo.toml b/protocols/v1/Cargo.toml index 3f81a65947..a91775406a 100644 --- a/protocols/v1/Cargo.toml +++ b/protocols/v1/Cargo.toml @@ -25,6 +25,3 @@ binary_sv2 = { path = "../v2/binary-sv2/binary-sv2" } [dev-dependencies] quickcheck = "1" quickcheck_macros = "1" - -[package.metadata.docs.rs] -all-features = true diff --git a/roles/roles-utils/network-helpers/Cargo.toml b/roles/roles-utils/network-helpers/Cargo.toml index 233a7c9e5c..45175dd963 100644 --- a/roles/roles-utils/network-helpers/Cargo.toml +++ b/roles/roles-utils/network-helpers/Cargo.toml @@ -32,4 +32,4 @@ with_serde = ["binary_sv2/with_serde", "serde", "codec_sv2/with_serde"] with_buffer_pool = ["codec_sv2/with_buffer_pool"] [package.metadata.docs.rs] -all-features = true +features = ["with_buffer_pool", "with_tokio", "async_std"] \ No newline at end of file diff --git a/roles/roles-utils/rpc/Cargo.toml b/roles/roles-utils/rpc/Cargo.toml index 58eef9a540..49b1d56bc7 100644 --- a/roles/roles-utils/rpc/Cargo.toml +++ b/roles/roles-utils/rpc/Cargo.toml @@ -22,6 +22,3 @@ base64 = "0.21.5" hyper = { version = "1.1.0", features = ["full"] } hyper-util = { version = "0.1", features = ["full"] } http-body-util = "0.1" - -[package.metadata.docs.rs] -all-features = true diff --git a/utils/bip32-key-derivation/Cargo.toml b/utils/bip32-key-derivation/Cargo.toml index 2bcdd6fe12..b9424dd5b4 100644 --- a/utils/bip32-key-derivation/Cargo.toml +++ b/utils/bip32-key-derivation/Cargo.toml @@ -25,6 +25,3 @@ slip132 = "0.10" [dev-dependencies] toml = { version = "0.5.6", git = "https://github.com/diondokter/toml-rs", default-features = false, rev = "c4161aa" } - -[package.metadata.docs.rs] -all-features = true \ No newline at end of file diff --git a/utils/error-handling/Cargo.toml b/utils/error-handling/Cargo.toml index 1999d7bcb8..67baf94cdd 100644 --- a/utils/error-handling/Cargo.toml +++ b/utils/error-handling/Cargo.toml @@ -9,6 +9,3 @@ homepage = "https://stratumprotocol.org" repository = "https://github.com/stratum-mining/stratum" license = "MIT OR Apache-2.0" keywords = ["stratum", "mining", "bitcoin", "protocol"] - -[package.metadata.docs.rs] -all-features = true \ No newline at end of file diff --git a/utils/key-utils/Cargo.toml b/utils/key-utils/Cargo.toml index 7d0213bbaa..428f700c14 100644 --- a/utils/key-utils/Cargo.toml +++ b/utils/key-utils/Cargo.toml @@ -29,6 +29,3 @@ serde = { version = "1.0.89", features = ["derive","alloc"], default-features = [dev-dependencies] toml = { version = "0.5.6", git = "https://github.com/diondokter/toml-rs", default-features = false, rev = "c4161aa" } - -[package.metadata.docs.rs] -all-features = true \ No newline at end of file From 757b9ef12bdbf6763aa5ed27a026b75a919608cf Mon Sep 17 00:00:00 2001 From: plebhash Date: Mon, 20 Jan 2025 12:22:50 -0300 Subject: [PATCH 2/2] cover `std` on `[package.metadata.docs.rs]` for `noise_sv2` and `codec_sv2`.. added via #1238 and #1346 --- protocols/v2/codec-sv2/Cargo.toml | 2 +- protocols/v2/noise-sv2/Cargo.toml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/protocols/v2/codec-sv2/Cargo.toml b/protocols/v2/codec-sv2/Cargo.toml index 56a1d413ee..1e75bd14d1 100644 --- a/protocols/v2/codec-sv2/Cargo.toml +++ b/protocols/v2/codec-sv2/Cargo.toml @@ -31,4 +31,4 @@ with_serde = ["binary_sv2/with_serde", "serde", "framing_sv2/with_serde", "buffe with_buffer_pool = ["framing_sv2/with_buffer_pool"] [package.metadata.docs.rs] -features = ["with_buffer_pool", "noise_sv2"] +features = ["with_buffer_pool", "noise_sv2", "std"] \ No newline at end of file diff --git a/protocols/v2/noise-sv2/Cargo.toml b/protocols/v2/noise-sv2/Cargo.toml index 52810daa46..ba8fdf698e 100644 --- a/protocols/v2/noise-sv2/Cargo.toml +++ b/protocols/v2/noise-sv2/Cargo.toml @@ -33,3 +33,6 @@ panic = "unwind" [profile.release] panic = "abort" + +[package.metadata.docs.rs] +features = ["std"]