From 88068d3da3fbf07b8b51b5baebc9654a9191b041 Mon Sep 17 00:00:00 2001 From: Soren Soe <2106410+stsoe@users.noreply.github.com> Date: Thu, 19 Feb 2026 08:36:50 -0800 Subject: [PATCH 1/2] Fix build-windows.yml more back-slash fixes Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com> --- .github/workflows/build-windows.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index bb45020a9e7..adca8fab90e 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -61,15 +61,16 @@ jobs: - name: Configure CMake (Release) run: | - $vcpkgRoot = "${{ github.workspace }}\vcpkg" + # Use forward slashes so generated cmake_install.cmake has no backslash escape issues + $vcpkgRoot = "${{ github.workspace }}/vcpkg" $triplet = "x64-windows" - $kronos = "$vcpkgRoot\installed\$triplet" - $src = "${{ github.workspace }}\src" - $build = "${{ github.workspace }}\build\WRelease" + $kronos = "$vcpkgRoot/installed/$triplet" + $src = "${{ github.workspace }}/src" + $build = "${{ github.workspace }}/build/WRelease" New-Item -ItemType Directory -Force -Path $build cmake -B $build -S $src ` -G "Visual Studio 17 2022" -A x64 ` - -DCMAKE_TOOLCHAIN_FILE="$vcpkgRoot\scripts\buildsystems\vcpkg.cmake" ` + -DCMAKE_TOOLCHAIN_FILE="$vcpkgRoot/scripts/buildsystems/vcpkg.cmake" ` -DVCPKG_TARGET_TRIPLET=x64-windows ` -DKHRONOS="$kronos" ` -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ` From b9aac6cc98dade8b74a217749c5331811cdb95d5 Mon Sep 17 00:00:00 2001 From: Soren Soe <2106410+stsoe@users.noreply.github.com> Date: Thu, 19 Feb 2026 09:12:53 -0800 Subject: [PATCH 2/2] Fix build-windows.yml more back-slash fixes Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com> --- .github/workflows/build-windows.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index adca8fab90e..ddb562eb069 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -61,12 +61,13 @@ jobs: - name: Configure CMake (Release) run: | - # Use forward slashes so generated cmake_install.cmake has no backslash escape issues - $vcpkgRoot = "${{ github.workspace }}/vcpkg" + # github.workspace expands with backslashes on Windows; normalize to forward slashes for CMake + $ws = "${{ github.workspace }}" -replace '\\', '/' + $vcpkgRoot = "$ws/vcpkg" $triplet = "x64-windows" $kronos = "$vcpkgRoot/installed/$triplet" - $src = "${{ github.workspace }}/src" - $build = "${{ github.workspace }}/build/WRelease" + $src = "$ws/src" + $build = "$ws/build/WRelease" New-Item -ItemType Directory -Force -Path $build cmake -B $build -S $src ` -G "Visual Studio 17 2022" -A x64 ` @@ -79,15 +80,16 @@ jobs: - name: Build (Release) run: | - $build = "${{ github.workspace }}/build/WRelease" + $ws = "${{ github.workspace }}" -replace '\\', '/' + $build = "$ws/build/WRelease" cmake --build $build --config Release --verbose shell: pwsh - name: Install (staging) run: | - # Use forward slashes to avoid cmake_install.cmake syntax errors (backslash escape sequences) - $build = "${{ github.workspace }}/build/WRelease" - $prefix = "${{ github.workspace }}/build/WRelease/xilinx/xrt" + $ws = "${{ github.workspace }}" -replace '\\', '/' + $build = "$ws/build/WRelease" + $prefix = "$ws/build/WRelease/xilinx/xrt" cmake --install $build --config Release --prefix $prefix --verbose shell: pwsh