Item not visible in third-person view

[TekhnaeRaav]

I was looking at myself in third persons view to test the mod, but whenever I switch to a type of flower or the screwdriver it flashes the object in my hand and then disappears. After this nothing appears anymore until I change my view again, but flowers and screwdriver still don't appear.

I'm not sure if any other objects do this.

[AndrejIT]

It may be important to know, if you your Minetest version is 4 or 5.

[stujones11]

This is a known issue and clearly a minetest bug since the item re-appears after you toggle the view-mode. I am not sure if there is an issue open for this but it's something I intend to look into when I have time. Until then I should at least add a note to the readme. Incidentally, this does not affect the item's appearance to other players in multiplayer mode, only the third-person view.

I'm not sure if any other objects do this.

Indeed they do, this happens every time the new item requires a rotation change. Since there is currently no way to alter the rotation of an attached item, it is necessary to detach then re-attach the item with the new rotation, so the minetest bug is that attachments are not visible to the client when attached in third-person view. Likely an easy fix for someone familiar with that area of the engine code.

This patch fixes it for me:

diff --git a/src/content_cao.cpp b/src/content_cao.cpp
index d15c53e7..46f6c7d7 100644
--- a/src/content_cao.cpp
+++ b/src/content_cao.cpp
@@ -1712,7 +1712,9 @@ void GenericCAO::processMessage(const std::string &data)
 		if (!m_is_local_player) {
 			m_attached_to_local = getParent() != NULL && getParent()->isLocalPlayer();
 			// Objects attached to the local player should be hidden by default
-			m_is_visible = !m_attached_to_local;
+			// in first person view
+			if (m_client->getCamera()->getCameraMode() < CAMERA_MODE_THIRD)
+				m_is_visible = !m_attached_to_local;
 		}
 
 		updateAttachments();

Is this in the MT bugtracker?

[HybridDog]

There's a PR for this; your code changes look familiar: https://github.com/minetest/minetest/pull/8046/files

Ah right, thanks!

[appgurueu]

Should have been fixed by luanti-org/luanti#10015 ?