Skip to content

[Xverse] connect return types are incorrect #459

@pradel

Description

@pradel

Describe the bug

The types in this package are defined like this

export interface AddressEntry {
    symbol?: string;
    address: string;
    publicKey: string;
}

export interface GetAddressesResult {
    addresses: AddressEntry[];
}

But what's returned by xverse is different

{
    "id": "xxx",
    "walletType": "software",
    "addresses": [
        {
            "address": "xxx",
            "publicKey": "xxx",
            "purpose": "ordinals",
            "addressType": "p2tr",
            "walletType": "software"
        },
        {
            "address": "xxx",
            "publicKey": "xxx",
            "purpose": "payment",
            "addressType": "p2wpkh",
            "walletType": "software"
        },
        {
            "address": "xxx",
            "publicKey": "xxx",
            "purpose": "stacks",
            "addressType": "stacks",
            "walletType": "software"
        }
    ],
    "network": {
        "bitcoin": {
            "name": "Testnet4"
        },
        "stacks": {
            "name": "Testnet4"
        }
    }
}

To Reproduce

Just connect with Xverse

Expected behavior

The response should match this package return types

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions