From 373a3db9282f2f92a474bd4cf659db5cff7ceb9a Mon Sep 17 00:00:00 2001 From: Acts1631 Date: Wed, 16 Sep 2026 19:43:52 -0400 Subject: [PATCH] Validate kart IDs in soccer goal notifications Reject goal notifications with an out-of-range kart ID before indexing the local kart array. --- src/modes/soccer_world.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/modes/soccer_world.cpp b/src/modes/soccer_world.cpp index 1f9e93888a1..0cb4b8506f5 100644 --- a/src/modes/soccer_world.cpp +++ b/src/modes/soccer_world.cpp @@ -642,6 +642,13 @@ void SoccerWorld::handlePlayerGoalFromServer(const NetworkString& ns) sd.m_handicap_level = (HandicapLevel)ns.getUInt8(); } + if (sd.m_id >= m_karts.size()) + { + Log::warn("SoccerWorld", "Ignoring goal for invalid kart id %d.", + sd.m_id); + return; + } + if (first_goal) { m_red_scorers.push_back(sd);