From 65b22b3ead559677e1dd6b5b34e8a9653138d415 Mon Sep 17 00:00:00 2001 From: Simon Garnier Date: Thu, 10 Oct 2024 16:52:33 -0400 Subject: [PATCH 1/4] Update cran-comments.md --- cran-comments.md | 62 ++++++------------------------------------------ 1 file changed, 7 insertions(+), 55 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 089fdc8..86ba642 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,16 +1,16 @@ ## Test environments -* local M1 OS X 14.1.1, R 4.3.2 -* local M1 OS X 14.1.1, R-devel +* local M1 OS X 15.0.1, R 4.4.1 +* local M1 OS X 15.0.1, R-devel * Github Actions "windows-latest (release)" * Github Actions "macOS-latest (release)" * Github Actions "ubuntu-latest (release)" * Github Actions "ubuntu-latest (devel)" * Github Actions "ubuntu-latest (oldrel-1)" -* r-hub Windows Server 2022, R-devel, 64 bit -* r-hub Ubuntu Linux 20.04.1 LTS, R-release, GCC -* r-hub Fedora Linux, R-devel, clang, gfortran -* r-hub Debian Linux, R-devel, GCC ASAN/UBSAN +* r-hub ubuntu-latest on GitHub +* r-hub macos-13 on GitHub +* r-hub macos-latest on GitHub +* r-hub windows-latest on GitHub * win-builder.r-project.org ## R CMD check results @@ -26,54 +26,6 @@ Downstream dependencies on CRAN and Bioconductor were checked with ‘revdepchec ## CRAN team comments -This submission fixes the following CRAN check issues: - -Version: 0.11.0 -Check: whether package can be installed -Result: WARN - Found the following significant warnings: - cec_r.cpp:65:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:75:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:123:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:133:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:160:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:167:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - See ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/CEC.Rcheck/00install.out’ for details. - * used C++ compiler: ‘Debian clang version 17.0.5 (1)’ -Flavor: r-devel-linux-x86_64-debian-clang - -Version: 0.11.0 -Check: C++ specification -Result: NOTE - Specified C++11: please drop specification unless essential -Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-x86_64 - -Version: 0.11.0 -Check: Rd files -Result: NOTE - checkRd: (-1) cec.Rd:164-165: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:166-168: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:169-172: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:173-175: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:176-177: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:178-180: Lost braces in \itemize; meant \describe ? - checkRd: (-1) cec.Rd:181-182: Lost braces in \itemize; meant \describe ? - checkRd: (-1) init.centers.Rd:19-20: Lost braces in \itemize; meant \describe ? - checkRd: (-1) init.centers.Rd:21-22: Lost braces in \itemize; meant \describe ? -Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc - -Version: 0.11.0 -Check: whether package can be installed -Result: WARN - Found the following significant warnings: - cec_r.cpp:65:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:75:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:123:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:133:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:160:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - cec_r.cpp:167:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] - See ‘/data/gannet/ripley/R/packages/tests-clang/CEC.Rcheck/00install.out’ for details. - * used C++ compiler: ‘clang version 17.0.5’ -Flavor: r-devel-linux-x86_64-fedora-clang +This submission fixes the noRemap CRAN check issue. --- From ea741e596b4125038afb5112b376badd839432b2 Mon Sep 17 00:00:00 2001 From: Simon Garnier Date: Tue, 3 Feb 2026 16:04:54 -0500 Subject: [PATCH 2/4] Fix typo in Makevars --- DESCRIPTION | 6 +++--- NEWS.md | 12 ++++++++++++ src/Makevars | 2 +- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index f41a135..243a858 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: CEC Type: Package Title: Cross-Entropy Clustering -Version: 0.11.2 -Date: 2024-10-10 +Version: 0.11.3 +Date: 2026-02-03 Authors@R: c( person("Kamieniecki", "Konrad", email = "konrad.kamieniecki@alumni.uj.edu.pl", role = c("aut")), @@ -30,6 +30,6 @@ Imports: utils NeedsCompilation: yes License: GPL-3 -RoxygenNote: 7.3.2 +RoxygenNote: 7.3.3 Suggests: covr diff --git a/NEWS.md b/NEWS.md index 244a9a6..c540f63 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,15 @@ +# CEC v0.11.3 + +## New features + +* N/A. + +## Minor improvements and fixes + +* Fixing typo in Makevars. + +--- + # CEC v0.11.2 ## New features diff --git a/src/Makevars b/src/Makevars index d441000..86c56ec 100644 --- a/src/Makevars +++ b/src/Makevars @@ -1,3 +1,3 @@ -CXX_STD = CXX1 +CXX_STD = CXX11 PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) OBJECTS = cec_r.o cec_starter.o init.o models/cov_utils.o params.o r_params.o r_result.o random.o split_starter.o starter.o variable_starter.o From 016ccb72ff3f85d80555204963354babd6555e65 Mon Sep 17 00:00:00 2001 From: Simon Garnier Date: Tue, 3 Feb 2026 16:06:01 -0500 Subject: [PATCH 3/4] Update R-CMD-check.yaml --- .github/workflows/R-CMD-check.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 0d11458..ac0ce9d 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -8,6 +8,8 @@ on: name: R-CMD-check +permissions: read-all + jobs: R-CMD-check: runs-on: ${{ matrix.config.os }} @@ -29,7 +31,7 @@ jobs: R_KEEP_PKG_SOURCE: yes steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: r-lib/actions/setup-pandoc@v2 From 652d8d2babde77412704a714ceabd9d33e35284a Mon Sep 17 00:00:00 2001 From: Simon Garnier Date: Tue, 3 Feb 2026 16:23:36 -0500 Subject: [PATCH 4/4] Update test-coverage.yaml --- .github/workflows/test-coverage.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml index 2c5bb50..f190d51 100644 --- a/.github/workflows/test-coverage.yaml +++ b/.github/workflows/test-coverage.yaml @@ -44,7 +44,7 @@ jobs: - name: Upload test results if: failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: coverage-test-failures path: ${{ runner.temp }}/package