Skip to content

Config builder subclasses have redundant methods. #252

@bauerfe

Description

@bauerfe
          I just double-checked that all the other classes are not changing the parent's behavior class.

To be precise:
The other classes add a:

config_dict.pop("weights_kill_bit")
config_dict.pop("biases_kill_bit")
config_dict.pop("neurons_value_kill_bit")

However, in the parent class, we find:

# config_dict["weights_kill_bit"] = torch.zeros_like(weights).bool().tolist()
# config_dict["biases_kill_bit"] = torch.zeros_like(biases).bool().tolist()
# "neurons_value_kill_bit" : torch.zeros_like(neurons_state).bool().tolist()

these entries will only be generated/updated when calling set_kill_bits.

Originally posted by @ssinhaleite in #245 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions