Build of source fails on 'external' directories

[chrisco484]

I was following the "Getting Started" steps, using the option where I download the source and compile it into, presumably a static lib, rather than use the single header option.

i.e.

Alternatively, download the latest release then follow:
Build instructions;

So I have the source downloaded and then run a CMake build but get errors regarding missing CMakeList.txt files in some 'external' directories:

I'm using SDL3pp release 0.4 and Windows/Visual Studio 2022:

PS C:\dev\SDL3pp-0.4> cmake -S . -B build
-- The CXX compiler identification is MSVC 19.44.35221.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.44.35207/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.44.35207/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:19 (add_subdirectory):
The source directory

C:/dev/SDL3pp-0.4/external/SDL

does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:50 (add_subdirectory):
The source directory

C:/dev/SDL3pp-0.4/external/SDL_image

does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:69 (add_subdirectory):
The source directory

C:/dev/SDL3pp-0.4/external/SDL_ttf

does not contain a CMakeLists.txt file.

Have I missed a step somewhere that puts files into those external directories?

[talesm]

Thanks for reporting, I'm going to check and reproduce your steps.

[talesm]

I added this new version https://github.com/talesm/SDL3pp/releases/tag/0.4.2 that have the SDL3pp_full-0.4.2.zip option that bundles the dependencies within, this should work better on windows.

Additionally I updated the README to add instructions on how to hook a SDL3 compiled separately, in case you want to use the one distributed by https://www.libsdl.org/

I hope this solves your problem.

[chrisco484]

@talesm

Thanks for making the changes that populate those external directories with the necessary SDL3 files, however, while it fixes those issues it now appears to show errors for some newer/other external directories:

-- Configuring SDL3_image 3.2.5
-- SDL3_image: Using vendored dav1d
CMake Error at external/SDL_image/CMakeLists.txt:461 (add_subdirectory):
The source directory

E:/dev/training/SDL3pp-0.4.2/external/SDL_image/external/dav1d

does not contain a CMakeLists.txt file.

-- SDL3_image: Using vendored aom
CMake Error at external/SDL_image/CMakeLists.txt:500 (add_subdirectory):
The source directory

E:/dev/training/SDL3pp-0.4.2/external/SDL_image/external/aom

does not contain a CMakeLists.txt file.

-- SDL3_image: Using vendored libavif
CMake Error at external/SDL_image/cmake/PrivateSdlFunctions.cmake:238 (message):
Could not find CMakeLists.txt for libavif in external/libavif.

Run the download script in the external folder, or re-configure with
-DSDLIMAGE_VENDORED=OFF to use system packages.
Call Stack (most recent call first):
external/SDL_image/CMakeLists.txt:517 (sdl_check_project_in_subfolder)

-- Configuring incomplete, errors occurred!

[talesm]

Thanks for commenting, I'm reopening the issue to further investigate.

[talesm]

I don't have an Windows machine available right now to figure this out and the instructions are working on Linux. I'll have to figure out how to gets my hands on one, but meanwhile, can you try to use the ExternalProject way?

You just need to add the following to your main project cmake:

include(ExternalProject)

ExternalProject_Add(SDL3ppExternal
  GIT_REPOSITORY git@github.com:talesm/SDL3pp.git
  GIT_TAG 0.5.0
  GIT_SUBMODULES_RECURSE ON
  GIT_SHALLOW ON # Optional, just allow download a bit faster
  GIT_PROGRESS ON
  CMAKE_ARGS -DSDL3PP_FORCE_BUNDLED=ON
  INSTALL_COMMAND ${CMAKE_COMMAND} --install . --prefix <INSTALL_DIR> 
)
# find_package(SDL3pp)
ExternalProject_Get_property(SDL3ppExternal INSTALL_DIR)
add_library(SDL3pp INTERFACE)
add_dependencies(SDL3pp SDL3ppExternal)
set_target_properties(SDL3pp PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${INSTALL_DIR}/include"
  INTERFACE_LINK_DIRECTORIES "${INSTALL_DIR}/lib/"
  INTERFACE_LINK_LIBRARIES "SDL3;SDL3_ttf;SDL3_image"
)
target_compile_features(SDL3pp INTERFACE cxx_std_23)

And then add it to your target more or less like this:

add_executable(my_app main.cpp) 
target_link_libraries(my_app PRIVATE SDL3pp)

[talesm]

Closing this issue as it should be covered on most recent release (0.9.0)