Extend guidelines about inclusion of assemblies#4834
Merged
maximiliankolb merged 1 commit intoMay 13, 2026
Conversation
github-actions
Bot
added
Needs tech review
Contributor
Author
|
Because this PR only tries to add a single sentence, I would also be OK providing a patch on top of #4830 if this PR gets merged first. cc @aneta-petrova & @jafiala |
maximiliankolb
removed
Needs tech review
|
The PR preview for a180d41 is available at theforeman-foreman-documentation-preview-pr-4834.surge.sh No diff compared to the current base |
jafiala
added
style review done
Member
|
#4830 will take time, let's merge this one first and I'll make sure to pull the change into the other one. |
maximiliankolb
force-pushed
the
guidelines_plus_two_assemblies
branch
from
3ae87a3 to
a180d41
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Extend guidelines about including assemblies in
master.adocwithout leveloffset or with leveloffset of two or higher.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Doing that would break orcharhino downstream builds.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Refs #4826
Contributor checklists
Please cherry-pick my commits into: