Delete old CV versions#4869
Conversation
|
The PR preview for 7f4dbd3 is available at theforeman-foreman-documentation-preview-pr-4869.surge.sh The following output files are affected by this PR: |
maximiliankolb
left a comment
There was a problem hiding this comment.
@jeremylenz Could you please check if this makes any sense to you? Are my assumptions about Katello orphan cleanup correct?
jafiala
left a comment
There was a problem hiding this comment.
Other than the Additional resources thing, LGTM
Tagging @sjha4 for review here, as he is more of a subject matter expert. |
Lennonka
left a comment
There was a problem hiding this comment.
Good draft. I have a couple of suggestions.
50d8cf4 to
0b6836e
Compare
maximiliankolb
left a comment
There was a problem hiding this comment.
Rebased to HEAD of "master" and applied all suggestions.
0b6836e to
7edb9a5
Compare
maximiliankolb
left a comment
There was a problem hiding this comment.
Rebased to HEAD of "master" and applied both suggestions.
7edb9a5 to
78aa8ec
Compare
Lennonka
left a comment
There was a problem hiding this comment.
Two optional nitpicks, LGTM otherwise.
This patch is a prerequisite to adding a module for Hammer CLI. $ rg -i "Deleting_Multiple_Content_View_Versions_" Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian
Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian
Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian
Suggested by Lena during review.
78aa8ec to
7f4dbd3
Compare
|
@sjha4 Can you please do a tech review? I already tested the commands locally on Foreman 3.18/Katello 4.20. |
|
Ack...Commands are correct.. 👍🏼 |
|
I'll review the abstracts in the scope of #4897, but we're good to merge. |
* Rename module to delete CV versions via WebUI This patch is a prerequisite to adding a module for Hammer CLI. $ rg -i "Deleting_Multiple_Content_View_Versions_" Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Add module to delete CV versions via CLI Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Add module to delete CV versions via Ansible Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian Refs https://theforeman.github.io/foreman-ansible-modules/latest/plugins/content_view_version_module.html#ansible-collections-theforeman-foreman-content-view-version-module * Add module to purge content view versions Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Move deleting CV versions to end of assembly Suggested by Lena during review. (cherry picked from commit 8f70ca4)
* Rename module to delete CV versions via WebUI This patch is a prerequisite to adding a module for Hammer CLI. $ rg -i "Deleting_Multiple_Content_View_Versions_" Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Add module to delete CV versions via CLI Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Add module to delete CV versions via Ansible Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian Refs https://theforeman.github.io/foreman-ansible-modules/latest/plugins/content_view_version_module.html#ansible-collections-theforeman-foreman-content-view-version-module * Add module to purge content view versions Tested on Foreman 3.18/Katello 4.20 with Hammer CLI katello 1.20. Refs https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian * Move deleting CV versions to end of assembly Suggested by Lena during review. (cherry picked from commit 8f70ca4)
What changes are you introducing?
Modules to delete old CV versions.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Response to https://community.theforeman.org/t/quick-question-on-automating-the-removal-of-old-content-versions/46402?u=maximilian which I consider valuable feedback so I tested it (minus the Ansible stuff in a Playbook) and wrote some docs.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: