Add index-containerized-katello.html to RCs#4885
Conversation
|
The PR preview for 28ab8d0 is available at theforeman-foreman-documentation-preview-pr-4885.surge.sh No diff compared to the current base |
|
|
||
| The following releases are supported and receive updates, including security updates: | ||
|
|
||
| <% releases_in_state('supported').each do |release| %> |
There was a problem hiding this comment.
Looking ahead: next Tuesday is Foreman 3.19 GA. Then we'll need to list the containerized build for 3.19, but not for 3.18. Have you looked at how to do that already?
There was a problem hiding this comment.
I think we'd need to edit the web/releases/3.18.json , L 135 looks like the right spot. Similar for 3.19, but those look correct.
Let me follow up in the team channel, because it does not seem relevant to this PR.
There was a problem hiding this comment.
You're right that for this PR it's not strictly needed, but Tuesday it will show up and I'm trying to think ahead.
What I tried to say is that if you add link:<%= release.path %>index-containerized-katello.html[Foreman with Katello (containerized)] in this block it will be listed for 3.18 and 3.19. So what I'd expect is that the rendered version is:
- Foreman 3.19
- Foreman on Enterprise Linux (EL)
- Foreman on Debian/Ubuntu
- Foreman with Katello 4.21 on Enterprise Linux (EL)
- Foreman with Katello 4.21 (containerized)
- Foreman 3.18
- Foreman on Enterprise Linux (EL)
- Foreman on Debian/Ubuntu
- Foreman with Katello 4.20 on Enterprise Linux (EL)
There was a problem hiding this comment.
@ekohl I get what you mean now.
I attempted a version check addition below, but not sure this is the correct approach. Please check (L26-28).
|
Cherry-picked to 3.19 3bc3dae |
What changes are you introducing?
Make index-containerized-katello.html visible among 3.19 RCs
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://redhat.atlassian.net/browse/SAT-45793
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: