Skip to content

Add index-containerized-katello.html to RCs#4885

Merged
ekohl merged 5 commits into
theforeman:masterfrom
jafiala:present-containerized-foreman-katello
Jun 8, 2026
Merged

Add index-containerized-katello.html to RCs#4885
ekohl merged 5 commits into
theforeman:masterfrom
jafiala:present-containerized-foreman-katello

Conversation

@jafiala

@jafiala jafiala commented May 28, 2026

Copy link
Copy Markdown
Contributor

What changes are you introducing?

Make index-containerized-katello.html visible among 3.19 RCs

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://redhat.atlassian.net/browse/SAT-45793

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

The PR preview for 28ab8d0 is available at theforeman-foreman-documentation-preview-pr-4885.surge.sh

No diff compared to the current base

show diff

Comment thread web/content/index.adoc.erb Outdated

The following releases are supported and receive updates, including security updates:

<% releases_in_state('supported').each do |release| %>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking ahead: next Tuesday is Foreman 3.19 GA. Then we'll need to list the containerized build for 3.19, but not for 3.18. Have you looked at how to do that already?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd need to edit the web/releases/3.18.json , L 135 looks like the right spot. Similar for 3.19, but those look correct.

Let me follow up in the team channel, because it does not seem relevant to this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that for this PR it's not strictly needed, but Tuesday it will show up and I'm trying to think ahead.

What I tried to say is that if you add link:<%= release.path %>index-containerized-katello.html[Foreman with Katello (containerized)] in this block it will be listed for 3.18 and 3.19. So what I'd expect is that the rendered version is:

  • Foreman 3.19
    • Foreman on Enterprise Linux (EL)
    • Foreman on Debian/Ubuntu
    • Foreman with Katello 4.21 on Enterprise Linux (EL)
    • Foreman with Katello 4.21 (containerized)
  • Foreman 3.18
    • Foreman on Enterprise Linux (EL)
    • Foreman on Debian/Ubuntu
    • Foreman with Katello 4.20 on Enterprise Linux (EL)

@jafiala jafiala Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl I get what you mean now.

I attempted a version check addition below, but not sure this is the correct approach. Please check (L26-28).

@jafiala jafiala marked this pull request as ready for review June 5, 2026 14:32
Comment thread web/content/index.adoc.erb Outdated

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works. Thanks!

@ekohl ekohl merged commit 93c9432 into theforeman:master Jun 8, 2026
8 checks passed
@jafiala

jafiala commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-picked to 3.19 3bc3dae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants