Remove waveform meta key; show waveform tab unconditionally

- Drop dead `waveform` field from meta.js (was never read by app code)
- Remove `hasVcdSignalDefinitions` guard so the Waves tab appears for
  any run that produces a VCD, including modules with no traced signals
- Update CLAUDE.md to drop the now-removed waveform field docs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: thomasahle

CLAUDE.md

@@ -29,7 +29,6 @@ Lessons are defined in a `parts → chapters → lessons` hierarchy and exported
 - `files.a`: starter files (keyed by virtual path like `/src/top.sv`)
 - `files.b`: solution delta (merged onto `a` to produce the solution)
 - `focus`: the default file to show in the editor
-- `waveform`: `'off'` | `'optional'` | `'required'` — controls waveform pane visibility
 - `html`: inline HTML string for the lesson description
 
 ### App State (`src/App.svelte`)

e2e/debug-cocotb.spec.js

@@ -10,6 +10,7 @@ test('cocotb: debug - check wasmTable', async ({ page }) => {
   await page.goto('/');
   await page.getByRole('button', { name: 'cocotb Basics' }).click();
   await page.getByRole('button', { name: /Your First cocotb Test/ }).click();
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('run-button').click();
 

e2e/formal.spec.js

@@ -14,6 +14,12 @@ async function goToLesson(page, chapterName, lessonName) {
   await expect(page.getByRole('heading', { level: 2, name: lessonName })).toBeVisible();
 }
 
+/** Open the gear menu then click the solve/reset button inside it. */
+async function clickSolve(page) {
+  await page.getByTestId('options-button').click();
+  await clickSolve(page);
+}
+
 // ── BMC: Bounded Model Checking ───────────────────────────────────────────────
 
 test('BMC: starter code has no assertion → verify does not prove anything', async ({ page }) => {
@@ -31,7 +37,7 @@ test('BMC: starter code has no assertion → verify does not prove anything', as
 test('BMC: solution proves all properties within the bound', async ({ page }) => {
   await goToLesson(page, 'Implication & BMC', 'Bounded Model Checking');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('verify-button').click();
 
   const logs = page.getByTestId('runtime-logs');
@@ -54,7 +60,7 @@ test('BMC: shows only verify button, no run button', async ({ page }) => {
 test('assume property: solution proves property with constraint', async ({ page }) => {
   await goToLesson(page, 'Formal Verification', 'assume property');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('verify-button').click();
 
   const logs = page.getByTestId('runtime-logs');
@@ -67,7 +73,7 @@ test('LEC: only shows verify (LEC) button, no run button', async ({ page }) => {
   await goToLesson(page, 'Formal Verification', 'Logical Equivalence Checking');
 
   await expect(page.getByTestId('verify-button')).toBeVisible();
-  await expect(page.getByTestId('verify-button')).toHaveText('verify (LEC)');
+  await expect(page.getByTestId('verify-button')).toHaveAttribute('aria-label', 'Verify (LEC)');
   await expect(page.getByTestId('run-button')).toHaveCount(0);
 });
 
@@ -86,7 +92,7 @@ test('LEC: buggy Impl is detected as NOT equivalent', async ({ page }) => {
 test('LEC: fixed Impl is proved equivalent to Spec', async ({ page }) => {
   await goToLesson(page, 'Formal Verification', 'Logical Equivalence Checking');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('verify-button').click();
 
   const logs = page.getByTestId('runtime-logs');

e2e/lessons.spec.js

@@ -12,6 +12,12 @@ async function goToLesson(page, chapterName, lessonName) {
   await expect(page.getByRole('heading', { level: 2, name: lessonName })).toBeVisible();
 }
 
+/** Open the gear menu then click the solve/reset button inside it. */
+async function clickSolve(page) {
+  await page.getByTestId('options-button').click();
+  await page.getByTestId('solve-button').click();
+}
+
 async function expectInterpretMode(logs) {
   await expect(logs).toContainText('--mode interpret');
   await expect(logs).not.toContainText('--compiled');
@@ -34,14 +40,24 @@ test('solve/reset toggles between solution and starter', async ({ page }) => {
   await page.goto('/');
   await page.getByRole('button', { name: 'next' }).click();
 
+  // Open menu and verify initial state
+  await page.getByTestId('options-button').click();
   const solveBtn = page.getByTestId('solve-button');
-  await expect(solveBtn).toHaveText('solve');
+  await expect(solveBtn).toHaveText('Show solution');
 
+  // Apply solution
   await solveBtn.click();
-  await expect(solveBtn).toHaveText('reset');
 
+  // Reopen menu and verify reset state
+  await page.getByTestId('options-button').click();
+  await expect(solveBtn).toHaveText('Reset to starter');
+
+  // Reset
   await solveBtn.click();
-  await expect(solveBtn).toHaveText('solve');
+
+  // Reopen menu and verify back to solve
+  await page.getByTestId('options-button').click();
+  await expect(solveBtn).toHaveText('Show solution');
 });
 
 // ── SystemVerilog Basics ──────────────────────────────────────────────────────
@@ -60,7 +76,7 @@ test('Welcome: run outputs Hello World', async ({ page }) => {
 test('Up-Counter: solution simulates and produces a waveform', async ({ page }) => {
   await goToLesson(page, 'Sequential Logic', 'Up-Counter');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('run-button').click();
 
   const logs = page.getByTestId('runtime-logs');
@@ -87,7 +103,7 @@ test('Modules and Ports: waveform renders after solve and run', async ({ page })
   await page.getByRole('button', { name: 'next' }).click();
   await expect(page.getByTestId('lesson-title')).toHaveText('Modules and Ports');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('run-button').click();
 
   const logs = page.getByTestId('runtime-logs');
@@ -105,9 +121,9 @@ test('Modules and Ports: waveform renders after solve and run', async ({ page })
 // ── SystemVerilog Assertions ──────────────────────────────────────────────────
 
 test('immediate-assert: solution passes assertions', async ({ page }) => {
-  await goToLesson(page, 'Your First Assertion', 'Immediate Assertions');
+  await goToLesson(page, 'Your First Formal Assertion', 'Immediate Assertions');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('verify-button').click();
 
   const logs = page.getByTestId('runtime-logs');
@@ -116,9 +132,9 @@ test('immediate-assert: solution passes assertions', async ({ page }) => {
 });
 
 test('sequence-basics: solution runs without errors', async ({ page }) => {
-  await goToLesson(page, 'Your First Assertion', 'Sequences and Properties');
+  await goToLesson(page, 'Your First Formal Assertion', 'Sequences and Properties');
 
-  await page.getByTestId('solve-button').click();
+  await clickSolve(page);
   await page.getByTestId('verify-button').click();
 
   const logs = page.getByTestId('runtime-logs');

e2e/live-smoke.spec.js

@@ -35,6 +35,7 @@ test('[app] loads and shows lesson navigation', async ({ page }) => {
 
 test('[sim] Welcome — run button produces output, no compile error', async ({ page }) => {
   await goToLesson(page, 'Introduction', 'Welcome');
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('run-button').click();
   const logs = page.getByTestId('runtime-logs');
@@ -43,6 +44,7 @@ test('[sim] Welcome — run button produces output, no compile error', async ({
 
 test('[sim] Concurrent Assertions — runtime assertions chapter visible, assertionFail produced', async ({ page }) => {
   await goToLesson(page, 'Runtime Assertions', 'Concurrent Assertions in Simulation');
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('run-button').click();
   const logs = page.getByTestId('runtime-logs');
@@ -52,6 +54,7 @@ test('[sim] Concurrent Assertions — runtime assertions chapter visible, assert
 
 test('[bmc] Immediate Assertions — verify runs z3', async ({ page }) => {
   await goToLesson(page, 'Your First Formal Assertion', 'Immediate Assertions');
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('verify-button').click();
   const logs = page.getByTestId('runtime-logs');
@@ -62,6 +65,7 @@ test('[bmc] Immediate Assertions — verify runs z3', async ({ page }) => {
 
 test('[bmc] Implication — verify runs z3', async ({ page }) => {
   await goToLesson(page, 'Implication & BMC', 'Implication: |-> and |=>');
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('verify-button').click();
   const logs = page.getByTestId('runtime-logs');
@@ -72,6 +76,7 @@ test('[bmc] Implication — verify runs z3', async ({ page }) => {
 
 test('[lec] Logical Equivalence Checking — z3 proves unsat', async ({ page }) => {
   await goToLesson(page, 'Formal Verification', 'Logical Equivalence Checking');
+  await page.getByTestId('options-button').click();
   await page.getByTestId('solve-button').click();
   await page.getByTestId('verify-button').click();
   const logs = page.getByTestId('runtime-logs');

e2e/qa-all-lessons.spec.js

@@ -79,10 +79,14 @@ for (const [index, lesson] of LESSONS.entries()) {
     await expect(page.getByTestId('lesson-title')).toHaveText(lesson.title, { timeout: 10_000 });
 
     // Apply the solution
+    await page.getByTestId('options-button').click();
     const solveBtn = page.getByTestId('solve-button');
     if (await solveBtn.count() > 0) {
-      await solveBtn.click();
-      await expect(solveBtn).toHaveText('reset', { timeout: 5_000 });
+      const label = ((await solveBtn.textContent()) ?? '').trim();
+      if (label !== 'Reset to starter') await solveBtn.click();
+      else await page.keyboard.press('Escape');
+    } else {
+      await page.keyboard.press('Escape');
     }
 
     const logs = page.getByTestId('runtime-logs');

e2e/solutions-live.spec.js

@@ -54,8 +54,8 @@ for (const lesson of LESSONS) {
   test(`[${lesson.runner ?? 'sim'}] ${lesson.title}`, async ({ page }) => {
     await goToLesson(page, lesson.chapter, lesson.title);
 
-    const solveBtn = page.getByTestId('solve-button');
-    await solveBtn.click();
+    await page.getByTestId('options-button').click();
+    await page.getByTestId('solve-button').click();
 
     const logs = page.getByTestId('runtime-logs');
 

e2e/solutions.spec.js

@@ -154,10 +154,9 @@ for (const lesson of LESSONS) {
   test(`[${lesson.runner ?? 'sim'}] ${lesson.title}`, async ({ page }) => {
     await goToLesson(page, lesson.chapter, lesson.title);
 
-    const solveBtn = page.getByTestId('solve-button');
-    // If already solved (button shows "reset"), re-apply by clicking reset then solve.
-    // More simply: clicking solve always sets the workspace to the solution.
-    await solveBtn.click();
+    // Open the gear menu then apply the solution.
+    await page.getByTestId('options-button').click();
+    await page.getByTestId('solve-button').click();
 
     const logs = page.getByTestId('runtime-logs');
 

e2e/uvm.spec.js

@@ -26,16 +26,17 @@ async function goToLesson(page, lesson) {
 }
 
 async function applySolution(page) {
+  await page.getByTestId('options-button').click();
   const solveBtn = page.getByTestId('solve-button');
-  if (await solveBtn.count() === 0) return;
+  if (await solveBtn.count() === 0) { await page.keyboard.press('Escape'); return; }
 
-  const label = ((await solveBtn.textContent()) ?? '').trim().toLowerCase();
-  if (label === 'reset') {
-    await solveBtn.click();
-    await expect(solveBtn).toHaveText(/solve/i);
+  const label = ((await solveBtn.textContent()) ?? '').trim();
+  if (label === 'Reset to starter') {
+    // Already solved — close menu and return
+    await page.keyboard.press('Escape');
+    return;
   }
   await solveBtn.click();
-  await expect(solveBtn).toHaveText(/reset/i);
 }
 
 async function expectCleanUvmRun(logs) {

e2e/waveform.spec.js

@@ -139,6 +139,89 @@ test('waveform toolbar buttons send correct commands', async ({ page }) => {
   }
 });
 
+test('transition_next selects earliest-transitioning signal, not alphabetically first', async ({ page }) => {
+  // Surfer displays signals alphabetically. For priority-enc the order is:
+  //   grant (idx 0), req (idx 1), valid (idx 2)
+  // But req and valid both transition at t=1 (the first simulation step), while
+  // grant only changes at t=2. So the auto-selected signal should be req or valid,
+  // NOT grant — otherwise transition_next from t=0 skips to a later timestamp.
+  await page.goto('/surfer/index.html#dev');
+  const crashBanner = page.getByText('Sorry, Surfer crashed');
+  let surferBootCrash = false;
+  try {
+    await expect(crashBanner).toBeVisible({ timeout: 3000 });
+    surferBootCrash = true;
+  } catch {
+    surferBootCrash = false;
+  }
+  test.skip(surferBootCrash, 'Surfer crashes in this Playwright environment (WebGL unavailable)');
+
+  await page.goto('/lesson/sv/priority-enc');
+  await page.evaluate(() => {
+    for (const key of Object.keys(localStorage)) {
+      if (key.startsWith('svt:')) localStorage.removeItem(key);
+    }
+  });
+
+  await page.getByTitle('Editor options').click();
+  await page.getByTestId('solve-button').click();
+  await page.getByTestId('run-button').click();
+
+  await expect(page.getByTestId('runtime-tab-waves')).toBeVisible({ timeout: 90_000 });
+  await page.getByTestId('runtime-tab-waves').click();
+
+  const waveFrame = page.getByTestId('waveform-frame-wrapper');
+  await expect(waveFrame).toHaveAttribute('data-wave-state', 'ready', { timeout: 30_000 });
+
+  // data-selected-signal is set when SetItemSelected succeeds in the polling loop.
+  // If it stays empty, id_of_name never returned a valid item (signals weren't ready).
+  // If it equals 'grant', the wrong signal was selected (alphabetically first ≠ earliest).
+  await expect.poll(
+    () => waveFrame.getAttribute('data-selected-signal'),
+    { timeout: 10_000, message: 'data-selected-signal should be set to a transitioning signal (not grant or empty)' }
+  ).toMatch(/^(req|valid)$/);
+});
+
+test('open-in-surfer button opens Surfer popup and sends VCD', async ({ page }) => {
+  // Intercept blob creation on the main page so we can verify the VCD blob is
+  // prepared for the popup (openInNewWindow creates a fresh blob URL from vcd prop).
+  await page.addInitScript(() => {
+    window._blobTexts = [];
+    const orig = URL.createObjectURL.bind(URL);
+    URL.createObjectURL = function (blob) {
+      const url = orig(blob);
+      if (blob.type === 'text/plain') {
+        blob.text().then((t) => window._blobTexts.push(t));
+      }
+      return url;
+    };
+  });
+
+  await runModulesAndPorts(page);
+  await page.getByTestId('runtime-tab-waves').click();
+
+  const waveFrame = page.getByTestId('waveform-frame-wrapper');
+  await expect(waveFrame).toHaveAttribute('data-wave-state', 'ready', { timeout: 30_000 });
+
+  const openBtn = page.getByTitle('Open in Surfer');
+  await expect(openBtn).toBeEnabled();
+
+  // window.open() fires the 'popup' event on the Playwright context.
+  const popupPromise = page.waitForEvent('popup');
+  await openBtn.click();
+  const popup = await popupPromise;
+
+  // The popup should navigate to the Surfer index page.
+  await popup.waitForURL(/surfer\/index\.html/, { timeout: 10_000 });
+
+  // A VCD blob should have been created for the popup.
+  // VCD files start with "$date" or "$timescale" while scope command files start with "scope_".
+  await expect.poll(
+    () => page.evaluate(() => window._blobTexts.some((t) => t.includes('$var'))),
+    { timeout: 5_000, message: 'Expected a VCD blob to be created for the popup' }
+  ).toBe(true);
+});
+
 test('concurrent-sim SVA assertion signal appears in VCD', async ({ page }) => {
   // Intercept URL.createObjectURL to capture the text of any VCD blob sent to Surfer.
   await page.addInitScript(() => {