test_umap test_that("backwards compatible for initial and target_weight args (#213)" failure with new irlba version

[bwlewis]

The test was previously skipped due to: skip_if_not_installed("irlba", "2.3.5.2").

Now that irlba is 2.3.7 this test fails.

Unfortunately I don't really understand the test. Perhaps skipping it again is an option? A better option might be to make it work with the current versions of uwot/irlba?

Thanks,

Bryan

[EmilHvitfeldt]

hey @bwlewis 👋

I'll take a look at it!

[EmilHvitfeldt]

@bwlewis do you mind testing against #271. if it works then I'll send in patch release of {embed}

[bwlewis]

I ran git checkout pr-271 and get a similar error:

── Error ('test-umap.R:435:3'): keep_original_cols - can prep recipes with it missing ──
<recipes_error_step/recipes_error/rlang_error/error/condition>
Error in `step_umap()`: Error in `step_umap()`:
Caused by error in `uwot()`:
! 'n_components' must be a positive integer
Backtrace:
     ▆
  1. ├─recipes::prep(rec)
  2. ├─recipes:::prep.recipe(rec)
  3. │ ├─recipes:::recipes_error_context(...)
  4. │ │ ├─base::withCallingHandlers(...)
  5. │ │ └─base::force(expr)
  6. │ ├─recipes::prep(x$steps[[i]], training = training, info = x$term_info)
  7. │ └─embed:::prep.step_umap(x$steps[[i]], training = training, info = x$term_info)
  8. │   ├─withr::with_seed(...)
  9. │   │ └─withr::with_preserve_seed(...)
 10. │   └─rlang::eval_tidy(umap_fit_call(x, y = y_name))
 11. ├─uwot::umap(...)
 12. │ └─uwot:::uwot(...)
 13. │   └─base::stop("'n_components' must be a positive integer")