Frontend integration fix#35
Merged
Merged
Conversation
…notmanas/PatientManagementSystem into frontend-integration-fix
…notmanas/PatientManagementSystem into frontend-integration-fix
totallynotmanas
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Frontend API Integration & Authentication Fixes
🎯 Overview
Complete frontend-backend API integration with critical authentication bug fixes. All API endpoints now properly integrated with graceful fallbacks and safe error handling.
🔧 Changes Made
1. Frontend API Service (
frontend/app/src/services/api.js)Endpoint Integration
Error Handling Improvements
response.okchecks before JSON parsingImpact: Prevents API call failures and ensures smooth user experience
2. Authentication Service (
frontend/app/src/services/supabaseAuth.js)Safe JSON Parsing Implementation
Applied safe JSON parsing pattern to all authentication functions to handle empty/null response bodies:
login()signup()verifyOtp()forgotPassword()validateResetToken()resetPassword()The Pattern Applied
Error Message Improvements
3. Critical Bug Fixes
Bug: Doctor 2FA OTP Verification Failing
Error Messages:
Root Cause:
ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(null)on invalid OTP (null body, not JSON)response.json()unconditionally before checkingresponse.okSolution:
response.json()in try-catch with fallbackImpact: Doctor login 2FA flow now works without crashes; proper error messages displayed to users
✅ Verification
🎯 Results
📝 Notes