From e3f17c0449b160527eff8fbc61c56c6e62e88897 Mon Sep 17 00:00:00 2001 From: Baptiste-Ferrand Date: Mon, 11 Aug 2025 22:59:51 +0200 Subject: [PATCH 1/2] fix error code 400 to 409 for a conflict --- src/entrypoints/api/routers/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/entrypoints/api/routers/profile.py b/src/entrypoints/api/routers/profile.py index a75820b..fdbe2a7 100644 --- a/src/entrypoints/api/routers/profile.py +++ b/src/entrypoints/api/routers/profile.py @@ -35,7 +35,7 @@ async def create_profile( legacy=dto.legacy, ) except DuplicateProfileError as e: - raise HTTPException(status_code=400, detail=str(e)) + raise HTTPException(status_code=409, detail=str(e)) except InvalidConfirmPasswordError as e: raise HTTPException(status_code=400, detail=str(e)) except InvalidFormatEmailError as e: From eb2cb2f4531d54bd3d24c9c62c783984fe8719cf Mon Sep 17 00:00:00 2001 From: Baptiste-Ferrand Date: Mon, 11 Aug 2025 23:05:39 +0200 Subject: [PATCH 2/2] =?UTF-8?q?update=20the=20test=20=F0=9F=91=8C?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/entrypoints/api/tests/profile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/entrypoints/api/tests/profile.py b/src/entrypoints/api/tests/profile.py index fb09c6a..456990e 100644 --- a/src/entrypoints/api/tests/profile.py +++ b/src/entrypoints/api/tests/profile.py @@ -78,7 +78,7 @@ async def test_06_user_cannot_update_roles(self, client): ) assert r.status_code == 403 - async def test_07_create_duplicate_user_profile_returns_400(self, client): + async def test_07_create_duplicate_user_profile_returns_409(self, client): payload = { "email": "alice@example.com", "password": "Secret123!", @@ -86,7 +86,7 @@ async def test_07_create_duplicate_user_profile_returns_400(self, client): "name": "Alice Dup" } r = await client.post("/profiles", json=payload) - assert r.status_code == 400 + assert r.status_code == 409 assert "already exists" in r.json()["detail"].lower() async def test_08_coach_cannot_update_user_profile(self, client):