Image size issue

[benjaminhlina]

So there's a minor issue with vdat-docker its more of annoyance and I'm not sure how to solve at the moment and it is is the following:

docker pull ghcr.io/trackyverse/vdat

it downloads an image that 1.3-1.4 Gb in size but then when you run

./vdat.sh Fathom_Installer.msi
or
./vdat.sh --help

it re downloads and says the image is out of date - the image size then goes up to 3.4 Gb. I'm assuming that it is downloading both arm64 and amd64 images. Once it does this it runs completely fine.

The bash lines that seem to be reinitiating this are the following

vdat-docker/vdat.sh

Line 25 in 262ab27

ghcr.io/trackyverse/vdat sh -c \

and

vdat-docker/vdat.sh

Line 99 in 262ab27

ghcr.io/trackyverse/vdat sh -c "$VDAT_CMD"

[benjaminhlina]

Alternatively if you just run

./vdat.sh Fathom_Installer.msi

It will download the image but at a size of 3.4 skipping the need to use docker pull

[benjaminhlina]

If I change the location of checking the host architecture from

vdat-docker/vdat.sh

Lines 79 to 86 in 262ab27

	HOST_ARCH=$(uname -m)
	# Default docker platform option empty
	DOCKER_PLATFORM=""
	# If host is arm64 (M1, ect MACs), force amd64 for vdat since vdat is 86-64
	if [ "$HOST_ARCH" = "aarch64" ] || [ "$HOST_ARCH" = "arm64" ]; then
	DOCKER_PLATFORM="--platform linux/amd64"
	fi

to above where the msi is extracted on line

vdat-docker/vdat.sh

Line 22 in 262ab27

and then add $DOCKER_PLATFORM \ to

vdat-docker/vdat.sh

Line 24 in 262ab27

-v $VDAT_TEMP_DIR:/VDAT \

it will pull in 1.56GB build with the platform amd/64 - this will run vdat but still produces the following warning.

WARNING: The requested image's platform (linux/amd64) does 
not match the detected host platform (linux/arm64/v8) and no specific platform was requested

if we leave it as is, this warning does not appear as both builds are being pulled in resulting in the overall size being 3.29 GB.

I am fine with this unless we want to reduce the overall size and keep it at 1.56-1.73 GB. I think this is only the case where it will pull both builds for when it detects the host architecture to be arm64.