`readlink -f` is not platform agnostic and fails on MacOS

[benjaminhlina]

Right now on MacOS the bash script will not allow files to be mounted as readlink -f does not work on MacOS. This SO kind of gets at this. This SO is better

The following needs to be edited to allow file mounting across Linux and Mac.

• vdat-docker/vdat.sh

  Line 48 in 262ab27

  VDAT_FULL_PATH=$(readlink -f "vdat.exe")

• vdat-docker/vdat.sh

  Line 64 in 262ab27

  THINGS_TO_MOUNT="-v ${PWD}/vdat_out:/VDAT/vdat_out -v $(readlink -f $3):/VDAT/$(basename $3)"

• vdat-docker/vdat.sh

  Line 75 in 262ab27

  THINGS_TO_MOUNT="-v $(readlink -f $2):/VDAT/$(basename $2)"

[mhpob]

I was using readlink to cheat and expand the file name to the full path, rather than worry about symlinks. I'll have to Google around and see what a more general way to do this would be.

Open to recommendations if you come across something.

[benjaminhlina]

That makes more sense why you used it. This SO seems better than what I posted and I think is close to what we want.

[benjaminhlina]

Both of these seem to be getting close to solving this:

• https://superuser.com/questions/1002825/getting-the-full-path-to-a-file-with-readlink-f-does-not-work-on-osx
• https://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac

[benjaminhlina]

I am assuming you would not be a fan of having the following at the beginning of the script and having vdat.exe be extracted to the root directory. This gets rid of this problem and works well for the {rvdat} but if solely running the container you may not want this to function this way and instead extract it into the current directory. I am thinking of how OTN runs through their vdats ect.

This might also have issue regarding permissions (e.g., read-write to the home directory).

VDAT_DIR="$HOME/vdat"
mkdir -p "$VDAT_DIR"

and then copying it to:

cp "$VDAT_TEMP_DIR/vdat.exe" "$VDAT_DIR/"

echo "vdat.exe copied to $VDAT_DIR"

I do have an alternative that I'm close to working but was thinking more in regards to [rvdat} and having it consistently extracted to the same location so the user doesn't end up with multiple copies of vdat.exe