Replies: 1 comment
-
|
I didnt get feedback or other suggestions, so i just implemented the least "destructive" way: adding 2 config options:
in #479 Also UDS is for now only available in |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Currently, with the IP way and us defaulting to ipv6, things like #402 can happen. Additionally, we currently dont use any authentication, meaning if somehow the port or IP is exposed to other than "localhost", it could be a problem.
The alternative could to use Unix Sockets (UDS), UDS is already supported by tokio and tonic, like in the tonic examples.
Windows also added support for UDS somewhere in Windows 10, but rust / tokio / tonic currently dont support the windows way yet, making it unix(Linux, BSD, mac) only for now.
I would either propose to add 2 new config options to
ComSettings:socketwhich would be the path for the socketprotocolwhich would set which mode to use (ip or unix socket)This way would preserve all options as they are and likely make parsing easier, but could be potentially confusing with many options.
Or changing the existing
ComSettings::addressto use path name (like/tmp/termusic.sock).This way would likely lessen confusion, but would make parsing a bit harder and not preserve the other options.
Which of these 2 ways would be better?
Beta Was this translation helpful? Give feedback.
All reactions