macOS' terminal rendering irregularities

[Porkepix]

Environment & Versions

• System: macOS
• Termusic version: master
• Rust version: current stable

Description of the Problem

As mentioned in #121 I open the related issue.

Rendering within macOS built-in terminal looks off on several aspects. See screenshots and cases below.
These issues are only visible on this specific terminal: every other tested terminals behave as intended, so maybe there's nothing that can be fixed on termusic side or its dependencies and it's just the terminal not supporting modern features.
I used the samples I got to test opus feature on the mac build.

Screenshots

First global screenshot:

I go down the list on the left, nothing special:

Then I go up the list, and everything becomes almost invisible: black on black, with the text slightly more black if you look very carefully:

Then comes the playlist, I just tab to it:

Finally I move with arrows around the playlist, see how different the rendering becomes (the track playing is still the same: so it lost its highlight, among other details):

[hasezoey]

As mentioned in #666 I open the related issue.

FYI the issue #666 is this current issue. Though i guess you meant #654.

Termusic version: master

Guessing from the screenshots, this does not look like you are running master. For example the TreeView should have arrow-like gylphs like ▶ in front of a item.
Sorry, i had the files confused. You dont have a sub-directory in there - hence why it did not have those gylphs.

---

I know that termusic's themeing is currently inconsistent (more-or-less due to what tui-realm-stdlib allows), but the issues listed here dont seem like they come from that.
Could you try to re-set the theme to native or any other theme and see if those issues still apply?

From a quick online search, it seems like this is a somewhat known problem with the default macos terminal, and if what i read is true, it does not support truecolor (more than 256 colors?), which could be the reason, at least if the theme is not native due to us using rgb colors.

[Porkepix]

As mentioned in #666 I open the related issue.

FYI the issue #666 is this current issue. Though i guess you meant #654.

Woops, indeed, bad issue number. But no I meant #121

I know that termusic's themeing is currently inconsistent (more-or-less due to what tui-realm-stdlib allows), but the issues listed here dont seem like they come from that. Could you try to re-set the theme to native or any other theme and see if those issues still apply?

From a quick online search, it seems like this is a somewhat known problem with the default macos terminal, and if what i read is true, it does not support truecolor (more than 256 colors?), which could be the reason, at least if the theme is not native due to us using rgb colors.

termusic on this mac runs on default config, I didn't changed anything regarding this. Config file wasn't even opened once.

EDIT: That's weird, ~/.config/termusic/ doesn't even exist, I'll check if it's on a different location on mac.

EDIT2: Answer's is in the README.

Here's tui.toml relevant content:

[theme]
name = "empty name"
author = "empty author"

[theme.primary]
background = "#101421"
foreground = "#fffbf6"

[theme.cursor]
text = "#1e1e1e"
cursor = "#ffffff"

[theme.normal]
black = "#2e2e2e"
red = "#eb4129"
green = "#abe047"
yellow = "#f6c744"
blue = "#47a0f3"
magenta = "#7b5cb0"
cyan = "#64dbed"
white = "#e5e9f0"

[hasezoey]

termusic on this mac runs on default config, I didn't changed anything regarding this. Config file wasn't even opened once.

Yes, assuming you ran termusic release 0.12.1, the default theme is a custom termusic theme, in master (and the next version) native is the default theme, hence my recommendation for testing the Native theme (which can be selected in the TUI config editor).

Here's tui.toml relevant content:

Yes that looks like the old Termusic Default theme.

[Porkepix]

termusic on this mac runs on default config, I didn't changed anything regarding this. Config file wasn't even opened once.

Yes, assuming you ran termusic release 0.12.1, the default theme is a custom termusic theme, in master (and the next version) native is the default theme, hence my recommendation for testing the Native theme (which can be selected in the TUI config editor).

Here's tui.toml relevant content:

Yes that looks like the old Termusic Default theme.

By removing the whole config directory, it recreates exactly the same thing with the same values.
The only difference is the addition of a [theme.bright] block.

[hasezoey]

By removing the whole config directory, it recreates exactly the same thing with the same values.

Yes. I dont know if there is a misunderstanding, but you need to start the TUI, go into the config editor (default keybind is SHIFT+C), navigate to the Themes & Colors Tab (via TAB), and select the Native Theme, apply it (via ENTER), then save the config (by exiting, for example via CTRL+S) (maybe even restart the TUI to fully apply it?)

[Porkepix]

By removing the whole config directory, it recreates exactly the same thing with the same values.

Yes. I dont know if there is a misunderstanding, but you need to start the TUI, go into the config editor (default keybind is SHIFT+C), navigate to the Themes & Colors Tab (via TAB), and select the Native Theme, apply it (via ENTER), then save the config (by exiting, for example via CTRL+S) (maybe even restart the TUI to fully apply it?)

My bad then, I thought by erasing every traces of old configuration files, as you said "in master (and the next version) native is the default theme" I thought it'd rewrite the config file to default to the native theme. It seems it didn't.
I'm curious as to what "native" is by the way!

As for the issue, yeah it works much better with native, bugs listed here are gone, the only remaining thing is the quit menu appearing a little bit dimmed:

[hasezoey]

My bad then, I thought by erasing every traces of old configuration files, as you said "in master (and the next version) native is the default theme" I thought it'd rewrite the config file to default to the native theme. It seems it didn't.

It should be the default in current master. The "native" theme should change all theme fields to native:

[theme]
name = "Native"
author = "Termusic Developers"

[theme.primary]
background = "native"
foreground = "native"

[theme.cursor]
text = "native"
cursor = "native"

[theme.normal]
black = "native"
red = "native"
green = "native"
yellow = "native"
blue = "native"
magenta = "native"
cyan = "native"
white = "native"

[theme.bright]
black = "native"
red = "native"
green = "native"
yellow = "native"
blue = "native"
magenta = "native"
cyan = "native"
white = "native"

[hasezoey]

I'm curious as to what "native" is by the way!

In termusic, themes are done by outputting custom RGB colors. Native here means it is outputting ANSI colors, and it is up to the terminal's color scheme to interpret the colors. (or said differently, Native does not require truecolor support)

This for example also allows easy integration with pywal, without having to generate the theme in the termusic custom format.

[Porkepix]

Well anyway except for the dimmed popup, native solve the issue.

And I'm pretty sure at the beginning even if I was erasing the whole config, starting again termusic was still showing me the default non-native values in tui.toml, but I can't reproduce it anymore so I guess either it was stored somewhere else (I doubt so), or termusic was still running without me noticing, or just I didn't tested properly.

I found other issues related to navigation in the config by checking this, but that's another story ><'