Allow to customize volume step

[g-plane]

Describe what you want

Currently volume step is hard-coded in:

termusic/server/src/server.rs

Line 39 in ce530f3

pub const VOLUME_STEP: VolumeSigned = 5;

It would be nice that the step can be customized in config.

Do you have already an idea for the implementation?

Read the volume step from config instead of the constant above.

[hasezoey]

FYI, i thought about doing this at some point in time, but the solution which i would want and consider the "best" is that the server does not have any hardcoded steps and instead gets the "stepping" from the interface, which currently is not possible and requires interface (proto) changes.

or TL;DR: the stepping config should be in the tui config, but would require server proto changes.

[g-plane]

Are there any reasons about not adding to server config?

[hasezoey]

Because it would, in my opinion, not be great to have a constant and a custom value interface, if there can be just one.
So theoretically a different client could have different steppings.

TL;DR: personal opinion

[g-plane]

For me it sounds that that (being in tui config) can cause inconsistency: it will be strange that increasing volume in client A will add a% but increasing in client B will add b% (a different value).

[tramhao]

Or we just simply using minimum step 1? Anyway we can press and hold the key, the key will repeat itself.

[g-plane]

That also makes sense.