fix: Address review nits for siblings tab

- Fix misleading comment in test: event indices now match push order
- Remove redundant current_ev variable, use outer-scope ev directly

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Mick

src/ui/detail_panel.cpp

@@ -690,19 +690,18 @@ void DetailPanel::render(const TraceModel& model, ViewState& view) {
 
         // Siblings tab (only for events with depth > 0)
         if (ev.depth > 0) {
-            const auto& current_ev = model.events()[view.selected_event_idx()];
             if (cached_siblings_event_idx_ != view.selected_event_idx()) {
                 cached_siblings_event_idx_ = view.selected_event_idx();
-                rebuild_siblings(model, current_ev, (uint32_t)view.selected_event_idx());
+                rebuild_siblings(model, ev, (uint32_t)view.selected_event_idx());
                 siblings_dirty_ = true;
             }
 
             if (cached_siblings_group_flag_ != siblings_group_by_name_ || siblings_dirty_) {
                 cached_siblings_group_flag_ = siblings_group_by_name_;
                 if (siblings_group_by_name_) {
                     double parent_dur = 0.0;
-                    if (current_ev.parent_idx >= 0) {
-                        parent_dur = model.events()[current_ev.parent_idx].dur;
+                    if (ev.parent_idx >= 0) {
+                        parent_dur = model.events()[ev.parent_idx].dur;
                     }
                     rebuild_siblings_aggregated(model, parent_dur);
                 }

tests/test_detail_siblings.cpp

@@ -28,9 +28,9 @@ static TraceModel make_sibling_model() {
     //  0: root [0, 200)  depth=0
     //  1:   A  [0,  50)  depth=1  parent=0
     //  2:   B  [50,100)  depth=1  parent=0
-    //  3:   C  [100,150) depth=1  parent=0
-    //  4:   C  [150,200) depth=1  parent=0
-    //  5:     D [50, 80) depth=2  parent=2  (child of B, no siblings)
+    //  3:     D [50, 80) depth=2  parent=2  (child of B, no siblings)
+    //  4:   C  [100,150) depth=1  parent=0
+    //  5:   C  [150,200) depth=1  parent=0
     TraceModel m;
     uint32_t n_root = m.intern_string("root");
     uint32_t n_a = m.intern_string("A");