Replacing Exceptions (where relevant)#1
Open
arnavgautam wants to merge 20 commits into
Open
Conversation
added 20 commits
November 19, 2018 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes to replace certain exceptions previously thrown, with a new system. This would instead write error messages to a globally-accessible struct, which could then be read by code that calls this library. This change also requires adding checks throughout the codebase whether or not the error struct has been written to, with new behavior if it has. The approach was essentially to replicate the behavior of exceptions, by just returning dummy values up the stack until we reach a point at which the error can be dealt with in a way that is semantically sound. However, this way doesn't require we compile to handle exceptions, which gives us a pretty sizeable speedup.