From a968e55a8c5df9bb1f4dddd8712a2bbe0a6efbeb Mon Sep 17 00:00:00 2001 From: BriBread Date: Tue, 7 Apr 2026 14:05:18 -0400 Subject: [PATCH 1/4] add terminationGracePeriodSeconds to backend --- charts/retool/Chart.yaml | 2 +- charts/retool/templates/deployment_backend.yaml | 3 +++ charts/retool/values.yaml | 4 ++++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/charts/retool/Chart.yaml b/charts/retool/Chart.yaml index da5a473b..7879b7a5 100644 --- a/charts/retool/Chart.yaml +++ b/charts/retool/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: retool description: A Helm chart for Kubernetes type: application -version: 6.10.0 +version: 6.10.1 maintainers: - name: Retool Engineering email: engineering+helm@retool.com diff --git a/charts/retool/templates/deployment_backend.yaml b/charts/retool/templates/deployment_backend.yaml index 66c39daa..5cc95911 100644 --- a/charts/retool/templates/deployment_backend.yaml +++ b/charts/retool/templates/deployment_backend.yaml @@ -44,6 +44,9 @@ spec: {{ toYaml .Values.ui.labels | indent 8 }} {{- end }} spec: + {{- if .Values.backend.terminationGracePeriodSeconds }} + terminationGracePeriodSeconds: {{ .Values.backend.terminationGracePeriodSeconds }} + {{- end }} serviceAccountName: {{ template "retool.serviceAccountName" . }} {{- if .Values.priorityClassName }} priorityClassName: "{{ .Values.priorityClassName }}" diff --git a/charts/retool/values.yaml b/charts/retool/values.yaml index 3705d39a..35d94aee 100644 --- a/charts/retool/values.yaml +++ b/charts/retool/values.yaml @@ -384,6 +384,10 @@ backend: # Labels for backend pods labels: {} + # (Optional) If set, make backend pods wait the specified time before + # kubernetes will forcibly kill them when they need to be rescheduled. + # terminationGracePeriodSeconds: 30 + ui: # Annotations for ui pods annotations: {} From 95bc53298a36a744543e7aa242718a2d0de842c2 Mon Sep 17 00:00:00 2001 From: BriBread Date: Tue, 7 Apr 2026 14:53:28 -0400 Subject: [PATCH 2/4] add default terminationGracePeriodSeconds --- charts/retool/templates/deployment_backend.yaml | 4 +--- charts/retool/values.yaml | 7 ++++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/charts/retool/templates/deployment_backend.yaml b/charts/retool/templates/deployment_backend.yaml index 5cc95911..57206e55 100644 --- a/charts/retool/templates/deployment_backend.yaml +++ b/charts/retool/templates/deployment_backend.yaml @@ -44,9 +44,7 @@ spec: {{ toYaml .Values.ui.labels | indent 8 }} {{- end }} spec: - {{- if .Values.backend.terminationGracePeriodSeconds }} - terminationGracePeriodSeconds: {{ .Values.backend.terminationGracePeriodSeconds }} - {{- end }} + terminationGracePeriodSeconds: {{ .Values.backend.terminationGracePeriodSeconds | default 136 }} serviceAccountName: {{ template "retool.serviceAccountName" . }} {{- if .Values.priorityClassName }} priorityClassName: "{{ .Values.priorityClassName }}" diff --git a/charts/retool/values.yaml b/charts/retool/values.yaml index 35d94aee..c7b6ba04 100644 --- a/charts/retool/values.yaml +++ b/charts/retool/values.yaml @@ -384,9 +384,10 @@ backend: # Labels for backend pods labels: {} - # (Optional) If set, make backend pods wait the specified time before - # kubernetes will forcibly kill them when they need to be rescheduled. - # terminationGracePeriodSeconds: 30 + # Make backend pods wait the specified time before kubernetes will forcibly kill them when they need to be rescheduled + # By default this is a 2 minutes + 15 seconds + 1 second (136) grace period to allow outstanding queries to complete + # Change this to 10 minutes 15 seconds + 1 second (616) if you are using long-running queries with a 10 minute timeout + # terminationGracePeriodSeconds: 136 ui: # Annotations for ui pods From 5168064ef5b197736b7d226c5609497971bb5141 Mon Sep 17 00:00:00 2001 From: BriBread Date: Tue, 7 Apr 2026 15:48:37 -0400 Subject: [PATCH 3/4] uncommented terminationGracePeriodSeconds --- charts/retool/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/retool/values.yaml b/charts/retool/values.yaml index c7b6ba04..1c925d2b 100644 --- a/charts/retool/values.yaml +++ b/charts/retool/values.yaml @@ -387,7 +387,7 @@ backend: # Make backend pods wait the specified time before kubernetes will forcibly kill them when they need to be rescheduled # By default this is a 2 minutes + 15 seconds + 1 second (136) grace period to allow outstanding queries to complete # Change this to 10 minutes 15 seconds + 1 second (616) if you are using long-running queries with a 10 minute timeout - # terminationGracePeriodSeconds: 136 + terminationGracePeriodSeconds: 136 ui: # Annotations for ui pods From bf8d4730dded386670f3ff9f56e485bc03fc9055 Mon Sep 17 00:00:00 2001 From: BriBread Date: Tue, 7 Apr 2026 15:50:12 -0400 Subject: [PATCH 4/4] update values.yaml to reflect the new changes --- values.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/values.yaml b/values.yaml index 3705d39a..1c925d2b 100644 --- a/values.yaml +++ b/values.yaml @@ -384,6 +384,11 @@ backend: # Labels for backend pods labels: {} + # Make backend pods wait the specified time before kubernetes will forcibly kill them when they need to be rescheduled + # By default this is a 2 minutes + 15 seconds + 1 second (136) grace period to allow outstanding queries to complete + # Change this to 10 minutes 15 seconds + 1 second (616) if you are using long-running queries with a 10 minute timeout + terminationGracePeriodSeconds: 136 + ui: # Annotations for ui pods annotations: {}