Skip to content

[quality] Missing unit tests for 4 build pipeline Python scripts #55

Description

@hanthor-hive-agent

Finding

The github-copr repository has 9 Python scripts in scripts/ but only 5 have corresponding tests in tests/. The following scripts have zero test coverage:

  1. scripts/cleanup.py — CI workspace cleanup logic
  2. scripts/copr-build-chain.py — COPR build dependency chaining
  3. scripts/generate-distributed-workflow.py — Distributed CI workflow generation
  4. scripts/parse-build-order.py — Build order YAML parsing

Additionally, the existing tests (tests/test_*.py) are minimal — 5 of them are only 14 lines each (just a basic import and null test).

Recommendation

Add meaningful unit tests for the untested scripts:

  1. cleanup.py — test cleanup logic with temp directories
  2. copr-build-chain.py — test dependency chain resolution with mock COPR API
  3. generate-distributed-workflow.py — test workflow YAML generation with fixture inputs
  4. parse-build-order.py — test YAML parsing with fixture build-order files

Expand existing tests to cover actual function behavior rather than just imports.

Priority

  • Impact: medium — these scripts are build pipeline utilities, not user-facing
  • Effort: medium — each script has clear input/output boundaries

Filed by quality agent (ACMM L4/L6 — full mode)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions