This repository was archived by the owner on May 31, 2021. It is now read-only.
Fix possible username truncation in version 49#2
Open
samphonic wants to merge 8 commits into
Open
Conversation
There was a skipped byte (index-4) in the inbyte array. Also, the copyOfRange math wasn't quite right and could result in the truncation of a reported username (e.g. for an 8-character username) I only fixed version 49, as that's the only version I have to test.
Will only activate sentry mode if connected user is on white-list.
Updated to protocol version 60, no changes that I'm aware of.
Updated to 1.5.2 (version 61) -- No changes to protocol that I'm aware of.
Changed protocol, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a skipped byte (index-4) in the inbyte array.
Also, the copyOfRange math wasn't quite right and could result in the
truncation of a reported username (e.g. for an 8-character username)
I only fixed version 49, as that's the only version I have to test.