From 06b57a76fba6cba2c573e0481253553ac2647678 Mon Sep 17 00:00:00 2001 From: madhums Date: Wed, 13 Jul 2022 14:42:04 +0200 Subject: [PATCH 1/2] Support Brave browser --- lib/capybara/apparition/browser/launcher/local.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/capybara/apparition/browser/launcher/local.rb b/lib/capybara/apparition/browser/launcher/local.rb index 0264bc6..ec5e320 100644 --- a/lib/capybara/apparition/browser/launcher/local.rb +++ b/lib/capybara/apparition/browser/launcher/local.rb @@ -143,7 +143,8 @@ def windows_path def macosx_path directories = ['', File.expand_path('~')] files = ['/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', - '/Applications/Chromium.app/Contents/MacOS/Chromium'] + '/Applications/Chromium.app/Contents/MacOS/Chromium', + '/Applications/Brave Browser.app/Contents/MacOS/Brave Browser'] directories.product(files).map(&:join).find { |f| File.exist?(f) } || find_first_binary('Google Chrome', 'Chromium') end From e863a7e2d34a1a82fd0530507ef155f7e06c9b1e Mon Sep 17 00:00:00 2001 From: madhums Date: Wed, 13 Jul 2022 15:19:39 +0200 Subject: [PATCH 2/2] add brave support for linux and windows too --- lib/capybara/apparition/browser/launcher/local.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/capybara/apparition/browser/launcher/local.rb b/lib/capybara/apparition/browser/launcher/local.rb index ec5e320..7e6a0d0 100644 --- a/lib/capybara/apparition/browser/launcher/local.rb +++ b/lib/capybara/apparition/browser/launcher/local.rb @@ -133,7 +133,7 @@ def path def windows_path envs = %w[LOCALAPPDATA PROGRAMFILES PROGRAMFILES(X86)] - directories = %w[\\Google\\Chrome\\Application \\Chromium\\Application] + directories = %w[\\Google\\Chrome\\Application \\Chromium\\Application \\BraveSoftware] files = %w[chrome.exe] directories.product(envs, files).lazy.map { |(dir, env, file)| "#{ENV[env]}\\#{dir}\\#{file}" } @@ -146,12 +146,12 @@ def macosx_path '/Applications/Chromium.app/Contents/MacOS/Chromium', '/Applications/Brave Browser.app/Contents/MacOS/Brave Browser'] directories.product(files).map(&:join).find { |f| File.exist?(f) } || - find_first_binary('Google Chrome', 'Chromium') + find_first_binary('Google Chrome', 'Chromium', 'Brave Browser') end def linux_path directories = %w[/usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /opt/google/chrome] - files = %w[google-chrome chrome chromium chromium-browser] + files = %w[google-chrome chrome chromium chromium-browser brave-browser] directories.product(files).map { |p| p.join('/') }.find { |f| File.exist?(f) } || find_first_binary(*files)