This function is currently defined at
|
def plot_param_func(bifs_obj): |
in utility.py.
Meta
This is a rather specialized function. Should it be in the package at all?
Note it induces a dependence on matplotlib, although there may be other such sources of dependence. That increases the overall footprint of the package.
Main Issue
Is this function still doing what it should?
gca(projection='3d') obsolescense
The most recent issue, noted in the comment starting at
|
# '3d' is not a documented projection type in https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.axes.html |
, is that the previous syntax for setting a 3D projection will soon be dropped. I have taken my best guess at how to get the same effect. It seems to work, but please review it.
In particular, as noted in the comment, projection="3d" is not one of the first-class alternatives (that is, 3d is not one of the alternatives) listed in the documentation, and so I'm concerned about whether it can work reliably.
erratic use of this function
bifs_cl_1D.py, an example program, and its 3D cousin both call this function, but the 2D version does not. Is that desirable?
As noted in #28, the usage by the 3D example itself is odd. It passes this function a 2D array, but then special logic in this function treats 2D arrays, but not 1D or 3D, as needing a 3D projection.
This function is currently defined at
bifs/bifs/bifs_util/util.py
Line 170 in c3c6111
Meta
This is a rather specialized function. Should it be in the package at all?
Note it induces a dependence on matplotlib, although there may be other such sources of dependence. That increases the overall footprint of the package.
Main Issue
Is this function still doing what it should?
gca(projection='3d') obsolescense
The most recent issue, noted in the comment starting at
bifs/bifs/bifs_util/util.py
Line 211 in c3c6111
In particular, as noted in the comment,
projection="3d"is not one of the first-class alternatives (that is, 3d is not one of the alternatives) listed in the documentation, and so I'm concerned about whether it can work reliably.erratic use of this function
bifs_cl_1D.py, an example program, and its 3D cousin both call this function, but the 2D version does not. Is that desirable?As noted in #28, the usage by the 3D example itself is odd. It passes this function a 2D array, but then special logic in this function treats 2D arrays, but not 1D or 3D, as needing a 3D projection.