From 4d8143fbd6d3295afae8501f642aab19ef8b3398 Mon Sep 17 00:00:00 2001 From: Ross Boylan Date: Mon, 18 Nov 2019 12:38:08 -0800 Subject: [PATCH 1/2] Fix comment in Issue 4: Uniform is not a reasonable prior. --- bifs/src/bifs_cl_1D.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bifs/src/bifs_cl_1D.py b/bifs/src/bifs_cl_1D.py index 58e651d..ae30427 100644 --- a/bifs/src/bifs_cl_1D.py +++ b/bifs/src/bifs_cl_1D.py @@ -25,10 +25,12 @@ # Set a few things: # Prior -mybifs.prior = "Gaussian" # Choices are currently: "Gaussian","Uniform" -# "Gaussian" is actually the default but for illustration... +mybifs.prior = "Gaussian" # Only choice currently +# A uniform prior is equivalent of maximum likelihood, which simply +# gives the current data value. But it does it very slowly. So don't do that. -# Lilelihood + +# Likelihood mybifs.likelihood = "Gaussian" # Choices are currently: "Gaussian","Rician" # "Gaussian" is actually the default but again for illustration... From f9f96e6804346ddee50433e44bcb32672717f8d4 Mon Sep 17 00:00:00 2001 From: Ross Boylan Date: Mon, 18 Nov 2019 12:38:08 -0800 Subject: [PATCH 2/2] Closes #4: In comment Uniform is not a reasonable prior. --- bifs/src/bifs_cl_1D.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bifs/src/bifs_cl_1D.py b/bifs/src/bifs_cl_1D.py index 58e651d..ae30427 100644 --- a/bifs/src/bifs_cl_1D.py +++ b/bifs/src/bifs_cl_1D.py @@ -25,10 +25,12 @@ # Set a few things: # Prior -mybifs.prior = "Gaussian" # Choices are currently: "Gaussian","Uniform" -# "Gaussian" is actually the default but for illustration... +mybifs.prior = "Gaussian" # Only choice currently +# A uniform prior is equivalent of maximum likelihood, which simply +# gives the current data value. But it does it very slowly. So don't do that. -# Lilelihood + +# Likelihood mybifs.likelihood = "Gaussian" # Choices are currently: "Gaussian","Rician" # "Gaussian" is actually the default but again for illustration...