This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Description
I'm submitting a…
Expected Behavior
Confirm on device works only on the device selected
Current Behavior
Confirm on device works with any supported device in the quorum
Possible Solution
Take the check here and make it more robust:
https://github.com/unchained-capital/caravan/blob/master/src/components/Slices/ConfirmAddress.jsx#L98-L101
Steps to Reproduce (for bugs)
Set up a wallet/address
Confirm on device with either device
Note that you are able to confirm with any device in the quorum (and not just the one selected)
Environment
Where are you running caravan: localhost
Operating system: Any
Browser and version: Any
[walden:~/code/caravan] master+ 130 ± npm ls caravan unchained-bitcoin unchained-wallets; echo -e npm: npm -v \nnode: node -v; uname -a | xargs echo | cut -d " " -f 1,3-15 || sw_vers
caravan@0.2.1 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13
└─┬ unchained-wallets@0.1.1
└── unchained-bitcoin@0.0.12
npm: 6.14.4
node: v12.16.2
Linux 5.7.6-arch1-1 #1 SMP PREEMPT Thu, 25 Jun 2020 00:14:47 +0000 x86_64 GNU/Linux
Reactions are currently unavailable
I'm submitting a…
Expected Behavior
Confirm on device works only on the device selected
Current Behavior
Confirm on device works with any supported device in the quorum
Possible Solution
Take the check here and make it more robust:
https://github.com/unchained-capital/caravan/blob/master/src/components/Slices/ConfirmAddress.jsx#L98-L101
Steps to Reproduce (for bugs)
Environment
[walden:~/code/caravan] master+ 130 ± npm ls caravan unchained-bitcoin unchained-wallets; echo -e npm:
npm -v\nnode:node -v; uname -a | xargs echo | cut -d " " -f 1,3-15 || sw_verscaravan@0.2.1 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13
└─┬ unchained-wallets@0.1.1
└── unchained-bitcoin@0.0.12
npm: 6.14.4
node: v12.16.2
Linux 5.7.6-arch1-1 #1 SMP PREEMPT Thu, 25 Jun 2020 00:14:47 +0000 x86_64 GNU/Linux