From 1b9ba2f1b7007720ed1fcc3ac53e4888448ae01e Mon Sep 17 00:00:00 2001 From: Ben Demboski Date: Wed, 9 Sep 2026 16:31:54 -0700 Subject: [PATCH] Remove Popover's default-override of elementContext: reference This causes `@floating-ui/dom` to only flip the popover when its _anchor_ is clipped, not when the popover itself is clipped, which is an unexpected default behavior. --- ember-primitives/src/components/popover.gts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/ember-primitives/src/components/popover.gts b/ember-primitives/src/components/popover.gts index 0c865e892..390c0f039 100644 --- a/ember-primitives/src/components/popover.gts +++ b/ember-primitives/src/components/popover.gts @@ -10,7 +10,7 @@ import { FloatingUI } from "../floating-ui.ts"; import type { Signature as FloatingUiComponentSignature } from "../floating-ui/component.gts"; import type { Signature as HookSignature } from "../floating-ui/modifier.ts"; import type { TOC } from "@ember/component/template-only"; -import type { ElementContext, Middleware } from "@floating-ui/dom"; +import type { Middleware } from "@floating-ui/dom"; import type { ModifierLike, WithBoundArgs } from "@glint/template"; export interface Signature { @@ -220,20 +220,13 @@ function maybeAddArrow(middleware: Middleware[] | undefined, element: Element | return result; } -function flipOptions(options: HookSignature["Args"]["Named"]["flipOptions"]) { - return { - elementContext: "reference" as ElementContext, - ...options, - }; -} - export const Popover: TOC =