[Backend Feature] : add Production Reminder Scheduler Never Starts Due to Mock Scheduler Initialization#145
Open
hrshjswniii wants to merge 11 commits into
Conversation
…rror, missing Query import, and test mocks/wrappers
…k Scheduler Initialization
…, and modernize startup lifecycle
Owner
|
please resolve merge conflicts then i will merge it. |
Owner
|
@hrshjswniii is work done ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend startup process was initializing a mock scheduler rather than the production scheduler responsible for monitoring user progress and triggering reminder workflows. As a result, automated reminders and progress checks were never executed in production environments.
Additionally, notification-related services existed in multiple locations (
alerts/andservices/) with overlapping responsibilities, creating code duplication, maintenance overhead, and uncertainty about which implementation was actually active.The application also relied on FastAPI's deprecated startup event mechanism, which generated framework deprecation warnings and was no longer aligned with current FastAPI best practices.
Solution
This PR promotes the production-ready scheduler to become the application's primary scheduling mechanism and consolidates all active notification services into a single, maintainable architecture.
Key improvements include:
services/layer.Files Affected
Added
backend/services/scheduler.pybackend/services/progress_checker.pybackend/services/twilio_service.pybackend/services/elevenlabs_service.pyModified
backend/main.pybackend/ruff.tomlbackend/tests/conftest.pyRemoved
backend/alerts/(entire directory)backend/services/reminder_scheduler.pybackend/services/call_service.pybackend/services/voice_service.pybackend/utils/progress_checker.pyUser Stories
Acceptance Criteria
Contribution Interest
Hiii @vanshaggarwal27 , i've implemented the issue i was assigned
please do review and feel free to merge the PR
fixes issue #135