[Feature] : [Issue Proposal] : Refactor Redundant Scheduler Architecture and Remove Mock Production Services#152
Open
hrshjswniii wants to merge 12 commits into
Conversation
…rror, missing Query import, and test mocks/wrappers
…k Scheduler Initialization
…, and modernize startup lifecycle
Owner
|
Please resovle merge conflict |
Owner
|
@hrshjswniii all tests are passed please resolve merge conflict so that i can merge this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend scheduler architecture contains multiple overlapping implementations, causing production reminder workflows to be unreliable and difficult to maintain. The application currently initializes a redundant scheduler layer while parallel scheduler and notification services exist in separate directories with duplicated responsibilities.
This creates several issues:
Solution
This PR refactors the backend architecture by consolidating scheduling and notification responsibilities into a single production-ready service layer.
The refactor:
serviceslayer.Files Affected
Added
backend/services/scheduler.pybackend/services/progress_checker.pybackend/services/twilio_service.pybackend/services/elevenlabs_service.pyModified
backend/main.pybackend/ruff.tomlbackend/tests/conftest.pyRemoved
backend/alerts/(entire directory)backend/services/reminder_scheduler.pybackend/services/call_service.pybackend/services/voice_service.pybackend/utils/progress_checker.pyUser Stories
Acceptance Criteria
Contribution Interest
Hiii @vanshaggarwal27 , i've implemented the issue assigned to me
please do review the PR and feel free to merge it
fixes issue #134