Skip to content

test: add coverage for invalid reminder user preferences (#177) #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durdana3105 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add coverage for invalid reminder user preferences (#177) #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions backend/tests/test_reminder_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,84 @@ async def test_enqueue_due_reminders_dedupes_jobs(app_module, mocker):
assert first["queued"] == 1
assert second["queued"] == 0
task.assert_called_once_with("due-user")
@pytest.mark.asyncio
async def test_find_due_reminder_users_skips_null_timezone(app_module):
from alerts import progress_checker

app_module.db.preferences.records.append(
{
"user_id": "user1",
"is_opted_in": True,
"timezone": None,
"whatsapp_number": "+911234567890",
}
)

progress_checker.db = app_module.db

users = await progress_checker.find_due_reminder_users(
datetime(2026, 1, 1, 17, 30, tzinfo=timezone.utc)
)

assert users == []

@pytest.mark.asyncio
async def test_find_due_reminder_users_skips_empty_timezone(app_module):
from alerts import progress_checker

app_module.db.preferences.records.append(
{
"user_id": "user1",
"is_opted_in": True,
"timezone": "",
"whatsapp_number": "+911234567890",
}
)

progress_checker.db = app_module.db

users = await progress_checker.find_due_reminder_users(
datetime(2026, 1, 1, 17, 30, tzinfo=timezone.utc)
)

assert users == []
@pytest.mark.asyncio
async def test_find_due_reminder_users_skips_missing_whatsapp(app_module):
from alerts import progress_checker

app_module.db.preferences.records.append(
{
"user_id": "user1",
"is_opted_in": True,
"timezone": "Asia/Kolkata",
"whatsapp_number": None,
}
)

progress_checker.db = app_module.db

users = await progress_checker.find_due_reminder_users(
datetime(2026, 1, 1, 17, 30, tzinfo=timezone.utc)
)

assert users == []
@pytest.mark.asyncio
async def test_find_due_reminder_users_skips_invalid_timezone(app_module):
from alerts import progress_checker

app_module.db.preferences.records.append(
{
"user_id": "user1",
"is_opted_in": True,
"timezone": "INVALID_TIMEZONE",
"whatsapp_number": "+911234567890",
}
)

progress_checker.db = app_module.db

users = await progress_checker.find_due_reminder_users(
datetime(2026, 1, 1, 17, 30, tzinfo=timezone.utc)
)

assert users == []