Fix/ resolve race condition in /generate-blog endpoint#204
Open
Unnati1007 wants to merge 2 commits into
Open
Conversation
Author
|
@vanshaggarwal27 please check the pr and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a race condition in
backend/main.pywithin the/generate-blogendpoint.Previously, the code checked the database for an existing successful record using
find_one(). However, because there was no concurrency locking mechanism, if multiple identical requests hit the server at the exact same time, all of them passed thefind_one()check simultaneously. This resulted in multiple expensive parallel calls to the AI provider and identical duplicate posts being pushed to the publishing platforms simultaneously.Fix #184
Implemented a distributed atomic lock using MongoDB's unique
_idindexing.Before processing a blog, the endpoint attempts to insert a record into a dedicated
lockscollection using a unique ID derived from the problem title, author, and user email. Only one request can successfully insert this lock. All other concurrent requests instantly receive aDuplicateKeyErrorand are cleanly rejected with a 400 Bad Request indicating the blog has already been published.Steps to Reproduce
uvicorn main:app --port 10000).threadingandrequestslibrary to send 5 concurrent HTTP POST requests to/generate-blogsimultaneously with identical JSON payloads.