From 0508ee82780bcc63f504ea7adab6c463fd9be0a3 Mon Sep 17 00:00:00 2001
From: "Harol A. Reina H." <hreina@verbara.io>
Date: Thu, 24 Sep 2026 18:34:40 -0500
Subject: [PATCH] chore(release): move the package validation baseline to 2.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Step two of the release ritual, the same shape #265 took after 2.5.3: with
2.6.0 published and indexed on nuget.org (29/29 verified against the flat
container, not against the workflow's own canary poll), ApiCompat compares
against it instead of against 2.5.3.

That makes all fourteen `CompatibilitySuppressions` entries obsolete, so the
three files go with the bump:

  src/Verbara.Sdk/CompatibilitySuppressions.xml                  2 entries
  src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml              6
  src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml  6

They existed to let the AudioSocket frame-type corrections and the
`CreateExternalMediaAsync` signature change pack against a 2.5.3 baseline that
still held the old surface. Against 2.6.0 there is no diff to suppress. Left in
place they would mask the *next* break of the same shape, which is the reason
they move with the baseline rather than later.

Verified, with a negative control rather than by trusting a green pack —
`dotnet pack` validation is incremental and a gate that never ran reports
success:

- baseline 2.6.0, no suppressions: `dotnet pack Verbara.Sdk.slnx -c Release`
  exits 0, produces 29 packages, zero errors and zero warnings.
- baseline 2.5.3, no suppressions: exits 1 with the six ApiCompat errors the
  Ari file used to carry — `CP0011: Value of field 'Uuid' in enum
  'AudioFrameType' changed from '0' to '1'` and five more. The gate is live, and
  the suppressions really are what was holding it.
---
 Directory.Build.props                         |  2 +-
 .../CompatibilitySuppressions.xml             | 86 -------------------
 .../CompatibilitySuppressions.xml             | 66 --------------
 src/Verbara.Sdk/CompatibilitySuppressions.xml | 54 ------------
 4 files changed, 1 insertion(+), 207 deletions(-)
 delete mode 100644 src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml
 delete mode 100644 src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml
 delete mode 100644 src/Verbara.Sdk/CompatibilitySuppressions.xml

diff --git a/Directory.Build.props b/Directory.Build.props
index 91361b76..16d49320 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -50,7 +50,7 @@
   <!-- Package validation: detect breaking API changes against the last published version -->
   <PropertyGroup Condition="$(MSBuildProjectDirectory.Contains('src'))">
     <EnablePackageValidation>true</EnablePackageValidation>
-    <PackageValidationBaselineVersion>2.5.3</PackageValidationBaselineVersion>
+    <PackageValidationBaselineVersion>2.6.0</PackageValidationBaselineVersion>
   </PropertyGroup>
 
   <!-- Analyzers for all projects (except SourceGenerators which targets netstandard2.0) -->
diff --git a/src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml b/src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml
deleted file mode 100644
index a8c30156..00000000
--- a/src/Verbara.Sdk.Ari/CompatibilitySuppressions.xml
+++ /dev/null
@@ -1,86 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
-<!--
-  Deliberate API breaks, declared rather than skipped.
-
-  == The AudioSocket wire format ==
-
-  Every entry in this group is a consequence of one fact: both AudioSocket implementations read a frame
-  header Asterisk does not send. Measured against a real Asterisk 22.9.0 with the real res_audiosocket.so
-  — the first bytes on the wire are `01 00 10` plus sixteen of UUID, so the header is one type byte and
-  two of big-endian length, and `0x01` is the identification frame rather than audio. The values these
-  suppressions cover described a protocol no Asterisk speaks, which is why no consumer can have
-  depended on them for anything that worked.
-
-  CP0011 (value changed): Uuid, Audio, Error and Hangup take the values res_audiosocket.h defines.
-  CP0002 (member removed): Silence describes a frame kind Asterisk has no code for.
-
-  == externalMedia gains a channelId parameter ==
-
-  CP0002 (member removed): AriChannelsResource.CreateExternalMediaAsync at its old nine-parameter arity.
-  The method is not deleted — it gained an optional `string? channelId` between `data` and its
-  cancellation token — but optional parameters are compile-time sugar and ApiCompat matches a member by
-  its full signature, so the nine-parameter member is genuinely absent from the assembly and a caller
-  compiled against 2.5.3 does not bind to the ten-parameter one without a rebuild.
-
-  The break is bought, not stumbled into. Asterisk keys an AudioSocket stream by the UUID the creator
-  supplied in `data`, and mints the ARI channel id itself, so a consumer holding only a Channel.Id has
-  no way to find its stream — `channelId` is the one ARI parameter that makes those two the same value.
-  The alternative that breaks nothing, minting the uuid and passing it only as `data`, was measured
-  working against a real Asterisk and rejected in the change proposal, because it fixes one activity and
-  leaves the capability unfixed. What a consumer has to do is written down in
-  docs/guides/externalmedia-channel-id-migration.md, per ADR-0028.
-
-  This file is committed on purpose. ADR-0055 records that letting `pack` generate it on the build
-  machine turns every difference into a suppression that never reaches the repository — which is
-  skipping validation while it reports green. Each entry here was read before it was kept; the
-  generated file was produced into a scratch path, compared entry by entry against the three breaks
-  this change intends, and found to hold those and nothing else.
-
-  These clear when PackageValidationBaselineVersion moves past the release that ships this change.
-  Do not add an entry here to make a build pass; add it because the break is intended and written down.
--->
-<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>F:Verbara.Sdk.Ari.Audio.AudioFrameType.Silence</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Verbara.Sdk.Ari.Resources.AriChannelsResource.CreateExternalMediaAsync(System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.Threading.CancellationToken)</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.Ari.Audio.AudioFrameType.Audio</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.Ari.Audio.AudioFrameType.Error</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.Ari.Audio.AudioFrameType.Hangup</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.Ari.Audio.AudioFrameType.Uuid</Target>
-    <Left>lib/net10.0/Verbara.Sdk.Ari.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.Ari.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-</Suppressions>
\ No newline at end of file
diff --git a/src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml b/src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml
deleted file mode 100644
index 047997b1..00000000
--- a/src/Verbara.Sdk.VoiceAi.AudioSocket/CompatibilitySuppressions.xml
+++ /dev/null
@@ -1,66 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
-<!--
-  Deliberate API breaks, declared rather than skipped.
-
-  Every entry here is a consequence of one fact: both AudioSocket implementations read a frame header
-  Asterisk does not send. Measured against a real Asterisk 22.9.0 with the real res_audiosocket.so —
-  the first bytes on the wire are `01 00 10` plus sixteen of UUID, so the header is one type byte and
-  two of big-endian length, and `0x01` is the identification frame rather than audio. The values these
-  suppressions cover described a protocol no Asterisk speaks, which is why no consumer can have
-  depended on them for anything that worked.
-
-  CP0011 (value changed): Uuid, Audio, Error and Hangup take the values res_audiosocket.h defines.
-  CP0002 (member removed): Silence, and its writer, describe a frame kind Asterisk has no code for.
-
-  This file is committed on purpose. ADR-0055 records that letting `pack` generate it on the build
-  machine turns every difference into a suppression that never reaches the repository — which is
-  skipping validation while it reports green. Each entry here was read before it was kept.
-
-  These clear when PackageValidationBaselineVersion moves past the release that ships this change.
-  Do not add an entry here to make a build pass; add it because the break is intended and written down.
--->
-<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>F:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketFrameType.Silence</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketSession.WriteSilenceAsync(System.Threading.CancellationToken)</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketFrameType.Audio</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketFrameType.Error</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketFrameType.Hangup</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0011</DiagnosticId>
-    <Target>F:Verbara.Sdk.VoiceAi.AudioSocket.AudioSocketFrameType.Uuid</Target>
-    <Left>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.VoiceAi.AudioSocket.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-</Suppressions>
\ No newline at end of file
diff --git a/src/Verbara.Sdk/CompatibilitySuppressions.xml b/src/Verbara.Sdk/CompatibilitySuppressions.xml
deleted file mode 100644
index 32a09ec0..00000000
--- a/src/Verbara.Sdk/CompatibilitySuppressions.xml
+++ /dev/null
@@ -1,54 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
-<!--
-  Deliberate API breaks, declared rather than skipped. This is the first such file in this package.
-
-  == externalMedia gains a channelId parameter ==
-
-  Both entries are one edit: IAriChannelsResource.CreateExternalMediaAsync gained an optional
-  `string? channelId` between `data` and its cancellation token. Optional parameters are compile-time
-  sugar and ApiCompat matches a member by its full signature, so the change reads as two separate
-  facts about the assembly, and both are true.
-
-  CP0002 (member removed): the nine-parameter member is genuinely absent. A caller compiled against
-  2.5.3 does not bind to the ten-parameter one without a rebuild.
-
-  CP0006 (interface member added): IAriChannelsResource is a shipped public interface and this member
-  has no default implementation, so every external implementation of it — a fake, a decorator, a proxy
-  — stops compiling until it adopts the parameter. Verbara.Sdk.Pro's ARI fakes are the known
-  population. That cost is named in the change's Architectural Risk rather than left for a consumer to
-  discover.
-
-  The break is bought, not stumbled into. Asterisk keys an AudioSocket stream by the UUID the creator
-  supplied in `data`, and mints the ARI channel id itself, so a consumer holding only a Channel.Id has
-  no way to find its stream — `channelId` is the one ARI parameter that makes those two the same value.
-  The alternative that breaks nothing, minting the uuid and passing it only as `data`, was measured
-  working against a real Asterisk and rejected in the change proposal, because it fixes one activity and
-  leaves the capability unfixed. What a consumer has to do is written down in
-  docs/guides/externalmedia-channel-id-migration.md, per ADR-0028.
-
-  This file is committed on purpose. ADR-0055 records that letting `pack` generate it on the build
-  machine turns every difference into a suppression that never reaches the repository — which is
-  skipping validation while it reports green. Each entry here was read before it was kept; the
-  generated file was produced into a scratch path, compared entry by entry against the breaks this
-  change intends, and found to hold those two and nothing else.
-
-  These clear when PackageValidationBaselineVersion moves past the release that ships this change.
-  Do not add an entry here to make a build pass; add it because the break is intended and written down.
--->
-<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:Verbara.Sdk.IAriChannelsResource.CreateExternalMediaAsync(System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.Threading.CancellationToken)</Target>
-    <Left>lib/net10.0/Verbara.Sdk.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0006</DiagnosticId>
-    <Target>M:Verbara.Sdk.IAriChannelsResource.CreateExternalMediaAsync(System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.String,System.Threading.CancellationToken)</Target>
-    <Left>lib/net10.0/Verbara.Sdk.dll</Left>
-    <Right>lib/net10.0/Verbara.Sdk.dll</Right>
-    <IsBaselineSuppression>true</IsBaselineSuppression>
-  </Suppression>
-</Suppressions>
\ No newline at end of file