Shipping Line Item Being Removed from Order and Marked As Overpaid

[RitterKnightCreative]

Describe the bug

I believe this started happening on the Craft Commerce 5.7 branch so I'm not sure if this is a Commerce bug ( or a Postie bug.

We recently upgraded Commerce to 5.7.1 (from 5.6.x) and on a few orders we're seeing shipping being dropped as a line item on the order.

However, in the sidebar, the shipping method still appears to be retained on the order so it doesn't appear to be completely "missing."

However, this is making the order appear overpaid.

It's not happening all of the time but the last 5 orders that I've seen, 2 of those were marked as overpaid. It's almost like after the order is being completed, Commerce is recalculating the order and since the shipping is being calculated in real time, it throws the line item out.

I've also filed a bug report with Craft.

Steps to reproduce

1. Customer checks out
2. On completion of the order, some orders appear to be overpaid with shipping being "removed".

Craft CMS version

5.10.12

Plugin version

5.0.19

Multi-site?

No response

Additional context

No response

[RitterKnightCreative]

@engram-design just making sure you saw this.

After some additional review, we are putting some adjustments on the price that Postie spits out... for example, we tack on an additional $6 if the address is residential and do some markups depending on the order's contents. it looks leek this might be a combination of my code that runs based on a couple Postie events and a Commerce bug.

As a follow-up, it also looks like Commerce is recalculating the order when an order status changes as well. I believe that's not supposed to happen? Those adjustments should be locked in. We had one customer get charged the correct amount but I noticed it went to overpaid when the order was then shipped and it dropped our adjustments. It seems like it's recalculating in real time now?

[engram-design]

Hmm, might have missed this somehow when it first came in, so thanks for the nudge.

Should be improved for the next release. To get this early, run composer require verbb/postie:"dev-craft-5 as 5.0.19".