Skip to content

Is batching appropriate (in this sink's current form)? #6

@cocowalla

Description

@cocowalla

I'm wondering if there is any benefit to this sink (in its current form) being an PeriodicBatchingSink?

As it stands, EmitBatch is simple sendin each message in the batch one-by-one, such that every message is sent using a new TCP connection.

I can see how this would make sense if #4 was implemented, as you would only flush at the end of every batch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions