From 5b92d115362bcd36861abcad2878ddd697c65f56 Mon Sep 17 00:00:00 2001 From: Awa Khouna Date: Mon, 13 Apr 2026 17:13:43 -0400 Subject: [PATCH 1/4] fix: reset status in Maxsat Explainer and adjust tolerance in Explanation decoding --- ocean/maxsat/_explainer.py | 1 + ocean/mip/_explanation.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ocean/maxsat/_explainer.py b/ocean/maxsat/_explainer.py index 7c37cc6..e09c51f 100644 --- a/ocean/maxsat/_explainer.py +++ b/ocean/maxsat/_explainer.py @@ -192,6 +192,7 @@ def explain( if random_seed != default_seed: msg = "There are no callbacks/random_seed for maxsat." warnings.warn(msg, category=UserWarning, stacklevel=2) + self.Status = "UNKNOWN" # reset status from previous solves self.solver.TimeLimit = max_time self.solver.n_threads = num_workers if num_workers is not None else 1 self.solver.verbose = verbose diff --git a/ocean/mip/_explanation.py b/ocean/mip/_explanation.py index 08eef34..42be791 100644 --- a/ocean/mip/_explanation.py +++ b/ocean/mip/_explanation.py @@ -99,7 +99,7 @@ def _continuous_index(self, feature: FeatureVar) -> int: return 0 if k >= n_intervals: return n_intervals - 1 - return k if self._atol < feature.mget(k).X else k - 1 + return k if 1 - self._atol < feature.mget(k).X else k - 1 return max(0, min(idx, n_intervals - 1)) From 2f7d9935fe04b571b0637bdff1163f08a9cbf59c Mon Sep 17 00:00:00 2001 From: Awa Khouna Date: Mon, 13 Apr 2026 17:17:49 -0400 Subject: [PATCH 2/4] feat: add Code of Conduct --- CODE_OF_CONDUCT.md | 128 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 CODE_OF_CONDUCT.md diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md new file mode 100644 index 0000000..6c8bd5d --- /dev/null +++ b/CODE_OF_CONDUCT.md @@ -0,0 +1,128 @@ +# Contributor Covenant Code of Conduct + +## Our Pledge + +We as members, contributors, and leaders pledge to make participation in our +community a harassment-free experience for everyone, regardless of age, body +size, visible or invisible disability, ethnicity, sex characteristics, gender +identity and expression, level of experience, education, socio-economic status, +nationality, personal appearance, race, religion, or sexual identity +and orientation. + +We pledge to act and interact in ways that contribute to an open, welcoming, +diverse, inclusive, and healthy community. + +## Our Standards + +Examples of behavior that contributes to a positive environment for our +community include: + +* Demonstrating empathy and kindness toward other people +* Being respectful of differing opinions, viewpoints, and experiences +* Giving and gracefully accepting constructive feedback +* Accepting responsibility and apologizing to those affected by our mistakes, + and learning from the experience +* Focusing on what is best not just for us as individuals, but for the + overall community + +Examples of unacceptable behavior include: + +* The use of sexualized language or imagery, and sexual attention or + advances of any kind +* Trolling, insulting or derogatory comments, and personal or political attacks +* Public or private harassment +* Publishing others' private information, such as a physical or email + address, without their explicit permission +* Other conduct which could reasonably be considered inappropriate in a + professional setting + +## Enforcement Responsibilities + +Community leaders are responsible for clarifying and enforcing our standards of +acceptable behavior and will take appropriate and fair corrective action in +response to any behavior that they deem inappropriate, threatening, offensive, +or harmful. + +Community leaders have the right and responsibility to remove, edit, or reject +comments, commits, code, wiki edits, issues, and other contributions that are +not aligned to this Code of Conduct, and will communicate reasons for moderation +decisions when appropriate. + +## Scope + +This Code of Conduct applies within all community spaces, and also applies when +an individual is officially representing the community in public spaces. +Examples of representing our community include using an official e-mail address, +posting via an official social media account, or acting as an appointed +representative at an online or offline event. + +## Enforcement + +Instances of abusive, harassing, or otherwise unacceptable behavior may be +reported to the community leaders responsible for enforcement at +thibaut.vidal@polymtl.ca. +All complaints will be reviewed and investigated promptly and fairly. + +All community leaders are obligated to respect the privacy and security of the +reporter of any incident. + +## Enforcement Guidelines + +Community leaders will follow these Community Impact Guidelines in determining +the consequences for any action they deem in violation of this Code of Conduct: + +### 1. Correction + +**Community Impact**: Use of inappropriate language or other behavior deemed +unprofessional or unwelcome in the community. + +**Consequence**: A private, written warning from community leaders, providing +clarity around the nature of the violation and an explanation of why the +behavior was inappropriate. A public apology may be requested. + +### 2. Warning + +**Community Impact**: A violation through a single incident or series +of actions. + +**Consequence**: A warning with consequences for continued behavior. No +interaction with the people involved, including unsolicited interaction with +those enforcing the Code of Conduct, for a specified period of time. This +includes avoiding interactions in community spaces as well as external channels +like social media. Violating these terms may lead to a temporary or +permanent ban. + +### 3. Temporary Ban + +**Community Impact**: A serious violation of community standards, including +sustained inappropriate behavior. + +**Consequence**: A temporary ban from any sort of interaction or public +communication with the community for a specified period of time. No public or +private interaction with the people involved, including unsolicited interaction +with those enforcing the Code of Conduct, is allowed during this period. +Violating these terms may lead to a permanent ban. + +### 4. Permanent Ban + +**Community Impact**: Demonstrating a pattern of violation of community +standards, including sustained inappropriate behavior, harassment of an +individual, or aggression toward or disparagement of classes of individuals. + +**Consequence**: A permanent ban from any sort of public interaction within +the community. + +## Attribution + +This Code of Conduct is adapted from the [Contributor Covenant][homepage], +version 2.0, available at +https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. + +Community Impact Guidelines were inspired by [Mozilla's code of conduct +enforcement ladder](https://github.com/mozilla/diversity). + +[homepage]: https://www.contributor-covenant.org + +For answers to common questions about this code of conduct, see the FAQ at +https://www.contributor-covenant.org/faq. Translations are available at +https://www.contributor-covenant.org/translations. \ No newline at end of file From 2e8202b9549ead0f64067c6736d33a93d724db70 Mon Sep 17 00:00:00 2001 From: Awa Khouna Date: Tue, 14 Apr 2026 14:05:21 -0400 Subject: [PATCH 3/4] fix: improve assertion error message in validate_sklearn_paths function --- tests/mip/utils.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/mip/utils.py b/tests/mip/utils.py index 07705c3..8d3dc73 100644 --- a/tests/mip/utils.py +++ b/tests/mip/utils.py @@ -109,7 +109,9 @@ def validate_sklearn_paths( else node.right ) is_path_valid: bool = bool(ind[0, ptr[t] + node.node_id]) - assert is_path_valid + assert is_path_valid, ( + f"Path validation failed for tree {t} at node {node.node_id}" + ) def validate_sklearn_pred( From e3420a1bc395c587d70aa66638456479f257e5f3 Mon Sep 17 00:00:00 2001 From: Awa Khouna Date: Tue, 14 Apr 2026 14:48:15 -0400 Subject: [PATCH 4/4] fix: update PATH_ATOL to Gurobi default tolerance for feasibility and integrality --- tests/mip/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mip/utils.py b/tests/mip/utils.py index 8d3dc73..316507f 100644 --- a/tests/mip/utils.py +++ b/tests/mip/utils.py @@ -18,7 +18,7 @@ from ocean.typing import Key -PATH_ATOL = 1e-9 +PATH_ATOL = 1e-6 # Gurobi default tolerance for feasibility and integrality. def check_solution(x: Array1D, explanation: Explanation) -> None: