Skip to content

Fix event handling in JS #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 2 commits into from
Mar 25, 2026
Merged

Fix event handling in JS #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3cc4c
Fix event handling in JS
almarklein Mar 25, 2026
b41bbc8
Merge branch 'main' into event
almarklein Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions jupyter_rfb/renderview-rfb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,20 +215,20 @@ class AnywidgetRenderView extends BaseRenderView {
if (event.type === 'resize') {
// Note that there can be multiple views that can possibly be individually resized.
// TODO: keep logical size in check between different views?
if (event.width * event.height <= 0) {
return // The element of a new view is temporarily zero-sized at initialization
if (event.width * event.height > 0) {
this.model.onEvent(event)
}
} else if (event.type === 'close') {
return // we don't close when one view closes, only when the widget closes
// we don't close when one view closes, only when the widget closes
} else if (event.type === 'show') {
this.isVisible = true
this.model.updateVisibility()
} else if (event.type === 'hide') {
this.isVisible = false
this.model.updateVisibility()
} else {
this.model.onEvent(event)
}

this.model.onEvent(event)
}
}

Expand Down
Loading